Refactor of category store class and removed unecessary stuff

Author: Gabriel Galvao da Gama

app/code/Magento/MediaContent/Model/GetAssetIdByContentFieldComposite.php

@@ -36,6 +36,7 @@ public function execute(string $value): array
     {
         $ids = [];
         foreach ($this->getAssetIdByContentFieldArray as $getAssetIdByContentField) {
+            // phpcs:ignore Magento2.Performance.ForeachArrayMerge
             $ids = array_merge($ids, $getAssetIdByContentField->execute($value));
         }
         return array_unique($ids);

app/code/Magento/MediaContentCatalog/Model/GetAssetIdByCategoryStore.php

@@ -7,18 +7,20 @@
 
 namespace Magento\MediaContentCatalog\Model;
 
+use Magento\Catalog\Api\CategoryManagementInterface;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\MediaContentApi\Model\GetAssetIdByContentFieldInterface;
 use Magento\Store\Api\GroupRepositoryInterface;
 use Magento\Store\Api\StoreRepositoryInterface;
 
 /**
- * Class responsible to return Asset id by content field
+ * Class responsible to return Asset id by category store
  */
 class GetAssetIdByCategoryStore implements GetAssetIdByContentFieldInterface
 {
     private const TABLE_CONTENT_ASSET = 'media_content_asset';
+    private const TABLE_CATALOG_CATEGORY = 'catalog_category_entity';
 
     /**
      * @var ResourceConnection
@@ -67,7 +69,7 @@ public function execute(string $value): array
     {
         $storeView = $this->storeRepository->getById($value);
         $storeGroup = $this->storeGroupRepository->get($storeView->getStoreGroupId());
-        $categoryIds = $this->getCategoryIdsByRootCategory($storeGroup->getRootCategoryId());
+        $categoryIds = $this->getCategoryIdsByRootCategory((int) $storeGroup->getRootCategoryId());
         $sql = $this->connection->getConnection()->select()->from(
             ['asset_content_table' => $this->connection->getTableName(self::TABLE_CONTENT_ASSET)],
             ['asset_id']
@@ -86,21 +88,15 @@ public function execute(string $value): array
         }, $result);
     }
 
-    private function getCategoryIdsByRootCategory($rootCategoryId)
+    /**
+     * This function returns an array of category ids that have content and are under the root parameter
+     *
+     * @param $rootCategoryId
+     * @return array
+     */
+    private function getCategoryIdsByRootCategory(int $rootCategoryId): array
     {
-        $contentCategoriesSql = $this->connection->getConnection()->select()->from(
-            ['asset_content_table' => $this->connection->getTableName(self::TABLE_CONTENT_ASSET)],
-            ['entity_id']
-        )->where(
-            'entity_type = ?',
-            $this->entityType
-        )->joinInner(
-            ['category_table' => $this->connection->getTableName('catalog_category_entity')],
-            'asset_content_table.entity_id = category_table.entity_id',
-            ['path']
-        );
-
-        $result = $this->connection->getConnection()->fetchAll($contentCategoriesSql);
+        $result = $this->getCategoryIdsAndPath();
 
         $result = array_filter($result, function ($item) use ($rootCategoryId) {
             $pathArray = explode("/", $item['path']);
@@ -117,4 +113,26 @@ private function getCategoryIdsByRootCategory($rootCategoryId)
             return $item['entity_id'];
         }, $result);
     }
+
+    /**
+     * This function returns an array of category_id and path of categories that have content
+     *
+     * @return array
+     */
+    private function getCategoryIdsAndPath(): array
+    {
+        $contentCategoriesSql = $this->connection->getConnection()->select()->from(
+            ['asset_content_table' => $this->connection->getTableName(self::TABLE_CONTENT_ASSET)],
+            ['entity_id']
+        )->where(
+            'entity_type = ?',
+            $this->entityType
+        )->joinInner(
+            ['category_table' => $this->connection->getTableName(self::TABLE_CATALOG_CATEGORY)],
+            'asset_content_table.entity_id = category_table.entity_id',
+            ['path']
+        );
+
+        return $this->connection->getConnection()->fetchAll($contentCategoriesSql);
+    }
 }

app/code/Magento/MediaContentCatalog/Model/GetAssetIdByProductStore.php

@@ -13,14 +13,11 @@
 use Magento\Store\Api\StoreRepositoryInterface;
 
 /**
- * Class responsible to return Asset id by content field
+ * Class responsible to return Asset ids by product store
  */
 class GetAssetIdByProductStore implements GetAssetIdByContentFieldInterface
 {
     private const TABLE_CONTENT_ASSET = 'media_content_asset';
-    private const ENTITY_STOREVIEW_RELATION = 'store_view';
-    private const ENTITY_STOREGROUP_RELATION = 'store_group';
-    private const ENTITY_WEBSITE_RELATION = 'website';
 
     /**
      * @var ResourceConnection