MAGETWO-39641: Place Order. Prevent Double Click

Author: Stanislav Idolov

app/code/Magento/Checkout/view/frontend/web/js/action/place-order.js

@@ -9,19 +9,18 @@ define(
         'mage/storage',
         'mage/url',
         'Magento_Checkout/js/model/error-processor',
-        'Magento_Customer/js/model/customer',
-        'underscore'
+        'Magento_Customer/js/model/customer'
     ],
-    function (quote, urlBuilder, storage, url, errorProcessor, customer, _) {
+    function (quote, urlBuilder, storage, url, errorProcessor, customer) {
         'use strict';
 
         return function (paymentData, redirectOnSuccess) {
-            var serviceUrl, payload;
+            var serviceUrl,
+                payload;
 
             redirectOnSuccess = redirectOnSuccess === false ? false : true;
-            /**
-             * Checkout for guest and registered customer.
-             */
+
+            /** Checkout for guest and registered customer. */
             if (!customer.isLoggedIn()) {
                 serviceUrl = urlBuilder.createUrl('/guest-carts/:quoteId/payment-information', {
                     quoteId: quote.getQuoteId()
@@ -40,7 +39,7 @@ define(
                     billingAddress: quote.billingAddress()
                 };
             }
-            storage.post(
+            return storage.post(
                 serviceUrl, JSON.stringify(payload)
             ).done(
                 function () {

app/code/Magento/Checkout/view/frontend/web/js/view/payment/default.js

@@ -46,14 +46,21 @@ define(
              * Place order.
              */
             placeOrder: function () {
-                var emailValidationResult = customer.isLoggedIn(),
+                var self = this,
+                    placeOrder,
+                    emailValidationResult = customer.isLoggedIn(),
                     loginFormSelector = 'form[data-role=email-with-possible-login]';
                 if (!customer.isLoggedIn()) {
                     $(loginFormSelector).validation();
                     emailValidationResult = Boolean($(loginFormSelector + ' input[name=username]').valid());
                 }
                 if (emailValidationResult && this.validate()) {
-                    placeOrderAction(this.getData(), this.redirectAfterPlaceOrder);
+                    this.isPlaceOrderActionAllowed(false);
+                    placeOrder = placeOrderAction(this.getData(), this.redirectAfterPlaceOrder);
+
+                    $.when(placeOrder).fail(function(){
+                        self.isPlaceOrderActionAllowed(true);
+                    });
                 }
             },
 

app/code/Magento/Payment/Model/IframeConfigProvider.php

@@ -26,6 +26,11 @@ class IframeConfigProvider implements ConfigProviderInterface
      */
     const DEFAULT_YEAR_LENGTH = 2;
 
+    /**
+     * Checkout identifier for transparent iframe payments
+     */
+    const CHECKOUT_IDENTIFIER = 'checkout_flow';
+
     /**
      * @var Repository
      */
@@ -93,7 +98,7 @@ public function getConfig()
                     'dateDelim' => [$this->methodCode => $this->getDateDelim()],
                     'cardFieldsMap' => [$this->methodCode => $this->getCardFieldsMap()],
                     'source' =>  [$this->methodCode => $this->getViewFileUrl('blank.html')],
-                    'controllerName' => [$this->methodCode => $this->getController()],
+                    'controllerName' => [$this->methodCode => self::CHECKOUT_IDENTIFIER],
                     'cgiUrl' => [$this->methodCode => $this->getCgiUrl()],
                     'placeOrderUrl' => [$this->methodCode => $this->getPlaceOrderUrl()],
                     'saveOrderUrl' => [$this->methodCode => $this->getSaveOrderUrl()],
@@ -167,16 +172,6 @@ protected function getViewFileUrl($fileId, array $params = [])
         }
     }
 
-    /**
-     * Retrieve the controller name
-     *
-     * @return string
-     */
-    protected function getController()
-    {
-        return $this->request->getControllerName();
-    }
-
     /**
      * Retrieve place order url on front
      *