Skip to content

Commit 0fcdcaa

Browse files
author
Mike Weis
committed
Merge remote-tracking branch 'mainline/develop' into develop
2 parents b850bbf + d447fa6 commit 0fcdcaa

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

app/code/Magento/Integration/Model/ResourceModel/Oauth/Consumer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ protected function _construct()
3737
public function _afterDelete(\Magento\Framework\Model\AbstractModel $object)
3838
{
3939
$connection = $this->getConnection();
40-
$connection->delete($this->getTable('oauth_nonce'), ['consumer_id' => $object->getId()]);
41-
$connection->delete($this->getTable('oauth_token'), ['consumer_id' => $object->getId()]);
40+
$connection->delete($this->getTable('oauth_nonce'), ['consumer_id = ?' => (int)$object->getId()]);
41+
$connection->delete($this->getTable('oauth_token'), ['consumer_id = ?' => (int)$object->getId()]);
4242
return parent::_afterDelete($object);
4343
}
4444

setup/src/Magento/Setup/Fixtures/FixtureModel.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,8 @@ public function loadFixtures()
110110
foreach ($files as $file) {
111111
$file = basename($file, '.php');
112112
/** @var \Magento\Setup\Fixtures\Fixture $fixture */
113-
$fixture = $this->objectManager->create(
114-
'Magento\Setup\Fixtures' . '\\' . $file,
115-
[
116-
'fixtureModel' => $this
117-
]
118-
);
113+
$type = 'Magento\Setup\Fixtures' . '\\' . $file;
114+
$fixture = new $type($this);
119115
$this->fixtures[$fixture->getPriority()] = $fixture;
120116
}
121117

setup/src/Magento/Setup/Mvc/Bootstrap/InitParamListener.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,16 @@ public function authPreDispatch($event)
123123
/** @var \Magento\Framework\App\State $adminAppState */
124124
$adminAppState = $objectManager->get('Magento\Framework\App\State');
125125
$adminAppState->setAreaCode(\Magento\Framework\App\Area::AREA_ADMIN);
126-
$objectManager->create(
127-
'Magento\Backend\Model\Auth\Session',
126+
/** @var \Magento\Backend\Model\Auth\Session $adminSession */
127+
$adminSession = $objectManager->create(
128+
\Magento\Backend\Model\Auth\Session::class,
128129
[
129-
'sessionConfig' => $objectManager->get('Magento\Backend\Model\Session\AdminConfig'),
130+
'sessionConfig' => $objectManager->get(\Magento\Backend\Model\Session\AdminConfig::class),
130131
'appState' => $adminAppState
131132
]
132133
);
133-
134-
if (!$objectManager->get('Magento\Backend\Model\Auth')->isLoggedIn()) {
134+
if (!$objectManager->get(\Magento\Backend\Model\Auth::class)->isLoggedIn()) {
135+
$adminSession->expireSessionCookie();
135136
$response = $event->getResponse();
136137
$response->getHeaders()->addHeaderLine('Location', 'index.php/session/unlogin');
137138
$response->setStatusCode(302);

0 commit comments

Comments
 (0)