MAGETWO-92986: Write Logs for Failed Process of Generating Factories in Extensions

Author: Yevhen Miroshnychenko

dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php

@@ -196,10 +196,10 @@ public function testGeneratorClassWithErrorSaveClassFile()
     {
         $exceptionMessageRegExp = '/Error: an object of a generated class may be a dependency for another object, '
             . 'but this dependency has not been defined or set correctly in the signature of the related construct '
-            . 'method\.\nDue to the current error, executing the CLI commands `bin\/magento setup:di:compile` '
-            . 'or `bin\/magento deploy:mode:set production` does not create the required generated classes\.\nMagento '
-            . 'cannot write a class file to the "generated" directory that is read\-only\. Before using the read-only '
-            . 'file system, the classes to be generated must be created beforehand in the "generated" directory\.\n'
+            . 'method\. Due to the current error, executing the CLI commands `bin\/magento setup:di:compile` '
+            . 'or `bin\/magento deploy:mode:set production` does not create the required generated classes\. Magento '
+            . 'cannot write a class file to the "generated" directory that is read-only\. Before using the read-only '
+            . 'file system, the classes to be generated must be created beforehand in the "generated" directory\. '
             . 'For details, see the "File systems access permissions" topic at http:\/\/devdocs\.magento\.com\.\n'
             . 'The specified ".*" file couldn\'t be written.  in \[.*\]/';
 

lib/internal/Magento/Framework/Code/Generator.php

@@ -113,7 +113,7 @@ public function generateClass($className)
             $this->tryToLoadSourceClass($className, $generator);
             if (!($file = $generator->generate())) {
                 /** @var $logger LoggerInterface */
-                $logger = $this->objectManager->get(LoggerInterface::class);
+                $logger = $this->getObjectManager()->get(LoggerInterface::class);
                 $errors = $generator->getErrors();
                 $message = implode(PHP_EOL, $errors) . ' in [' . $className . ']';
                 $logger->critical($message);

lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php

@@ -109,11 +109,11 @@ public function generate()
             }
         } catch (FileSystemException $e) {
             $message = 'Error: an object of a generated class may be a dependency for another object, but this '
-                . 'dependency has not been defined or set correctly in the signature of the related construct method.'
+                . 'dependency has not been defined or set correctly in the signature of the related construct method. '
                 . 'Due to the current error, executing the CLI commands `bin/magento setup:di:compile` or `bin/magento '
-                . 'deploy:mode:set production` does not create the required generated classes.'
+                . 'deploy:mode:set production` does not create the required generated classes. '
                 . 'Magento cannot write a class file to the "generated" directory that is read-only. Before using the '
-                . 'read-only file system, the classes to be generated must be created beforehand in the "generated" directory.'
+                . 'read-only file system, the classes to be generated must be created beforehand in the "generated" directory. '
                 . 'For details, see the "File systems access permissions" topic at http://devdocs.magento.com.';
             $this->_addError($message);
             $this->_addError($e->getMessage());

lib/internal/Magento/Framework/Code/Test/Unit/Generator/EntityAbstractTest.php

@@ -215,14 +215,16 @@ public function testGenerate(
     /**
      * @inheritdoc
      */
-    public function testGenerateFailure() {
-
-        $infoMessage = <<<'EOT'
-Error: an object of a generated class may be a dependency for another object, but this dependency has not been defined or set correctly in the signature of the related construct method.
-Due to the current error, executing the CLI commands `bin/magento setup:di:compile` or `bin/magento deploy:mode:set production` does not create the required generated classes.
-Magento cannot write a class file to the "generated" directory that is read-only. Before using the read-only file system, the classes to be generated must be created beforehand in the "generated" directory.
-For details, see the "File systems access permissions" topic at http://devdocs.magento.com.
-EOT;
+    public function testGenerateFailure()
+    {
+        $infoMessage = 'Error: an object of a generated class may be a dependency for another object, but this '
+            . 'dependency has not been defined or set correctly in the signature of the related construct method. '
+            . 'Due to the current error, executing the CLI commands `bin/magento setup:di:compile` or `bin/magento '
+            . 'deploy:mode:set production` does not create the required generated classes. '
+            . 'Magento cannot write a class file to the "generated" directory that is read-only. Before using the '
+            . 'read-only file system, the classes to be generated must be created beforehand in the "generated" directory. '
+            . 'For details, see the "File systems access permissions" topic at http://devdocs.magento.com.';
+
         $exceptionMessage = 'Some description';
 
         $abstractGetters = ['_getClassProperties', '_getClassMethods'];
@@ -254,6 +256,7 @@ public function testGenerateFailure() {
         $this->assertFalse($result);
         $this->assertEquals([$infoMessage, $exceptionMessage], $this->_model->getErrors());
     }
+
     /**
      * Prepares mocks for validation verification
      *