Skip to content

Commit 0f9ac99

Browse files
MC-38498: "Save to Address Book" in Admin checkout causes duplicate address book entries
1 parent 632a7c6 commit 0f9ac99

File tree

3 files changed

+63
-1
lines changed

3 files changed

+63
-1
lines changed
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Sales\ViewModel\Customer\Address\Billing;
9+
10+
use Magento\Framework\View\Element\Block\ArgumentInterface;
11+
use Magento\Sales\Model\AdminOrder\Create;
12+
use Magento\Quote\Model\Quote\Address as QuoteAddress;
13+
14+
/**
15+
* Customer address formatter
16+
*/
17+
class Address implements ArgumentInterface
18+
{
19+
/**
20+
* @var Create
21+
*/
22+
protected $orderCreate;
23+
24+
/**
25+
* Customer billing address
26+
*
27+
* @param Create $orderCreate
28+
*/
29+
public function __construct(
30+
Create $orderCreate
31+
) {
32+
$this->orderCreate = $orderCreate;
33+
}
34+
35+
/**
36+
* Return billing address object
37+
*
38+
* @return QuoteAddress
39+
*/
40+
public function getAddress(): QuoteAddress
41+
{
42+
return $this->orderCreate->getBillingAddress();
43+
}
44+
45+
/**
46+
* Get save billing address in the address book
47+
*
48+
* @return int
49+
*/
50+
public function getSaveInAddressBook(): int
51+
{
52+
return (int)$this->getAddress()->getSaveInAddressBook();
53+
}
54+
}

app/code/Magento/Sales/view/adminhtml/layout/sales_order_create_load_block_billing_address.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<arguments>
1313
<argument name="customerAddressFormatter" xsi:type="object">Magento\Sales\ViewModel\Customer\AddressFormatter</argument>
1414
<argument name="customerAddressCollection" xsi:type="object">Magento\Customer\Model\ResourceModel\Address\Collection</argument>
15+
<argument name="customerBillingAddress" xsi:type="object">Magento\Sales\ViewModel\Customer\Address\Billing\Address</argument>
1516
</arguments>
1617
</block>
1718
</referenceContainer>

app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ endif;
2424
*/
2525
$customerAddressFormatter = $block->getData('customerAddressFormatter');
2626

27+
/**
28+
* @var \Magento\Sales\ViewModel\Customer\Address\Billing\Address $billingAddress
29+
*/
30+
$billingAddress = $block->getData('customerBillingAddress');
31+
2732
/**
2833
* @var \Magento\Sales\Block\Adminhtml\Order\Create\Billing\Address|
2934
* \Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Address $block
@@ -114,7 +119,9 @@ endif; ?>
114119
type="checkbox"
115120
id="<?= $block->escapeHtmlAttr($block->getForm()->getHtmlIdPrefix()) ?>save_in_address_book"
116121
value="1"
117-
<?php if (!$block->getDontSaveInAddressBook() && !$block->getAddressId()): ?>
122+
<?php if ($billingAddress && $billingAddress->getSaveInAddressBook()): ?>
123+
checked="checked"
124+
<?php elseif ($block->getIsShipping() && !$block->getDontSaveInAddressBook() && !$block->getAddressId()): ?>
118125
checked="checked"
119126
<?php endif; ?>
120127
class="admin__control-checkbox"/>

0 commit comments

Comments
 (0)