Skip to content

Commit 0f572b6

Browse files
author
Yevhen Miroshnychenko
committed
MAGETWO-93042: [Backport to 2.2 ] Write Logs for Failed Process of Generating Factories in Extensions
1 parent d1cf05b commit 0f572b6

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ protected function _getNullDefaultValue()
323323
*
324324
* @return null|string
325325
*/
326-
private function extractParameterType(\ReflectionParameter $parameter): ?string
326+
private function extractParameterType(\ReflectionParameter $parameter)
327327
{
328328
/** @var string|null $typeName */
329329
$typeName = null;
@@ -353,7 +353,7 @@ private function extractParameterType(\ReflectionParameter $parameter): ?string
353353
*
354354
* @return null|ValueGenerator
355355
*/
356-
private function extractParameterDefaultValue(\ReflectionParameter $parameter): ?ValueGenerator
356+
private function extractParameterDefaultValue(\ReflectionParameter $parameter)
357357
{
358358
/** @var ValueGenerator|null $value */
359359
$value = null;

lib/internal/Magento/Framework/Code/Test/Unit/Generator/EntityAbstractTest.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -153,17 +153,17 @@ public function generateDataProvider()
153153
* @param bool $willWriteCode
154154
*
155155
* @dataProvider generateDataProvider
156-
* @covers EntityAbstract::generate
157-
* @covers EntityAbstract::getErrors
158-
* @covers EntityAbstract::getSourceClassName
159-
* @covers EntityAbstract::_getResultClassName
160-
* @covers EntityAbstract::_getDefaultResultClassName
161-
* @covers EntityAbstract::_generateCode
162-
* @covers EntityAbstract::_addError
163-
* @covers EntityAbstract::_validateData
164-
* @covers EntityAbstract::_getClassDocBlock
165-
* @covers EntityAbstract::_getGeneratedCode
166-
* @covers EntityAbstract::_fixCodeStyle
156+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::generate
157+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::getErrors
158+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::getSourceClassName
159+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_getResultClassName
160+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_getDefaultResultClassName
161+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_generateCode
162+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_addError
163+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_validateData
164+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_getClassDocBlock
165+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_getGeneratedCode
166+
* @covers \Magento\Framework\Code\Generator\EntityAbstract::_fixCodeStyle
167167
*/
168168
public function testGenerate(
169169
$errors = [],

0 commit comments

Comments
 (0)