Skip to content

Commit 0ef14c9

Browse files
committed
AC-2883::Disable max session size in admin - Unable to login to admin anymore
1 parent f1adf23 commit 0ef14c9

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

lib/internal/Magento/Framework/Session/SaveHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function read($sessionId): string
126126
$sessionMaxSize = $this->sessionMaxSizeConfig->getSessionMaxSize();
127127
$sessionSize = strlen($sessionData);
128128

129-
if ($sessionSize !== null && $sessionMaxSize < $sessionSize) {
129+
if ($sessionMaxSize !== null && $sessionMaxSize < $sessionSize) {
130130
$sessionData = '';
131131
if ($this->appState->getAreaCode() === Area::AREA_FRONTEND) {
132132
$this->messageManager->addErrorMessage(

lib/internal/Magento/Framework/Session/Test/Unit/SaveHandlerTest.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public function testWriteMoreThanSessionMaxSize(): void
132132

133133
$this->assertTrue($this->saveHandler->write("test_session_id", "testdata"));
134134
}
135-
135+
136136
public function testReadMoreThanSessionMaxSize(): void
137137
{
138138
$this->sessionMaxSizeConfigMock
@@ -148,4 +148,20 @@ public function testReadMoreThanSessionMaxSize(): void
148148

149149
$this->assertEquals(null, $this->saveHandler->read("test_session_id"));
150150
}
151+
152+
public function testReadSessionMaxZero(): void
153+
{
154+
$this->sessionMaxSizeConfigMock
155+
->expects($this->once())
156+
->method('getSessionMaxSize')
157+
->willReturn(0);
158+
159+
$this->saveHandlerAdapterMock
160+
->expects($this->once())
161+
->method('read')
162+
->with('test_session_id')
163+
->willReturn('test_session_data');
164+
165+
$this->assertEquals(null, $this->saveHandler->read("test_session_id"));
166+
}
151167
}

0 commit comments

Comments
 (0)