Skip to content

Commit 0ea7d50

Browse files
committed
Return scalar type instead of deferred
1 parent 4de3a9e commit 0ea7d50

File tree

1 file changed

+2
-18
lines changed
  • app/code/Magento/CatalogGraphQl/Model/Resolver/Product

1 file changed

+2
-18
lines changed

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/Image.php

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
use Magento\Catalog\Helper\ImageFactory as CatalogImageHelperFactory;
1111
use Magento\Catalog\Model\Product;
1212
use Magento\Framework\GraphQl\Config\Element\Field;
13-
use Magento\Framework\GraphQl\Query\Resolver\Value;
14-
use Magento\Framework\GraphQl\Query\Resolver\ValueFactory;
1513
use Magento\Framework\GraphQl\Query\ResolverInterface;
1614
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
1715

@@ -26,19 +24,11 @@ class Image implements ResolverInterface
2624
private $catalogImageHelperFactory;
2725

2826
/**
29-
* @var ValueFactory
30-
*/
31-
private $valueFactory;
32-
33-
/**
34-
* @param ValueFactory $valueFactory
3527
* @param CatalogImageHelperFactory $catalogImageHelperFactory
3628
*/
3729
public function __construct(
38-
ValueFactory $valueFactory,
3930
CatalogImageHelperFactory $catalogImageHelperFactory
4031
) {
41-
$this->valueFactory = $valueFactory;
4232
$this->catalogImageHelperFactory = $catalogImageHelperFactory;
4333
}
4434

@@ -51,7 +41,7 @@ public function resolve(
5141
ResolveInfo $info,
5242
array $value = null,
5343
array $args = null
54-
): Value {
44+
): array {
5545
if (!isset($value['model'])) {
5646
throw new \LogicException(__("Cannot resolve entity model"));
5747
}
@@ -66,15 +56,9 @@ public function resolve(
6656
['type' => $imageType]
6757
)->getUrl();
6858

69-
$imageData = [
59+
return [
7060
'url' => $imageUrl,
7161
'path' => $product->getData($imageType)
7262
];
73-
74-
$result = function () use ($imageData) {
75-
return $imageData;
76-
};
77-
78-
return $this->valueFactory->create($result);
7963
}
8064
}

0 commit comments

Comments
 (0)