MAGETWO-86295: 404 Error not found page ” issue in change status and update attribute from product grid

Author: StasKozar

app/code/Magento/Catalog/Test/Unit/Ui/Component/Product/MassActionTest.php

@@ -12,6 +12,9 @@
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\View\Element\UiComponent\ContextInterface;
 
+/**
+ * Test for Magento\Catalog\Ui\Component\Product\MassAction class.
+ */
 class MassActionTest extends \PHPUnit\Framework\TestCase
 {
     /**
@@ -34,6 +37,9 @@ class MassActionTest extends \PHPUnit\Framework\TestCase
      */
     private $massAction;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp()
     {
         $this->objectManager = new ObjectManager($this);
@@ -48,11 +54,14 @@ protected function setUp()
             [
                 'authorization' => $this->authorizationMock,
                 'context' => $this->contextMock,
-                'data' => []
+                'data' => [],
             ]
         );
     }
 
+    /**
+     * @return void
+     */
     public function testGetComponentName()
     {
         $this->assertTrue($this->massAction->getComponentName() === MassAction::NAME);
@@ -214,6 +223,7 @@ public function getPrepareDataProvider() : array
      * @param int $callNum
      * @param string $resource
      * @param bool $isAllowed
+     * @return void
      * @dataProvider isActionAllowedDataProvider
      */
     public function testIsActionAllowed(
@@ -231,7 +241,10 @@ public function testIsActionAllowed(
         $this->assertEquals($expected, $this->massAction->isActionAllowed($actionType));
     }
 
-    public function isActionAllowedDataProvider()
+    /**
+     * @return array
+     */
+    public function isActionAllowedDataProvider(): array
     {
         return [
             'other' => [true, 'other', 0,],
@@ -241,7 +254,6 @@ public function isActionAllowedDataProvider()
             'status-not-allowed' => [false, 'status', 1, 'Magento_Catalog::products', false],
             'attributes-allowed' => [true, 'attributes', 1, 'Magento_Catalog::update_attributes'],
             'attributes-not-allowed' => [false, 'attributes', 1, 'Magento_Catalog::update_attributes', false],
-
         ];
     }
 }

app/code/Magento/Catalog/Ui/Component/Product/MassAction.php

@@ -12,6 +12,9 @@
 use Magento\Framework\View\Element\UiComponent\ContextInterface;
 use Magento\Ui\Component\AbstractComponent;
 
+/**
+ * Provide validation of allowed massaction for user.
+ */
 class MassAction extends AbstractComponent
 {
     const NAME = 'massaction';
@@ -38,7 +41,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function prepare()
     {
@@ -62,7 +65,7 @@ public function prepare()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getComponentName(): string
     {
@@ -80,8 +83,6 @@ public function isActionAllowed(string $actionType): bool
         $isAllowed = true;
         switch ($actionType) {
             case 'delete':
-                $isAllowed = $this->authorization->isAllowed('Magento_Catalog::products');
-                break;
             case 'status':
                 $isAllowed = $this->authorization->isAllowed('Magento_Catalog::products');
                 break;