MAGETWO-50893: No _Threshold_ message is displayed after buying product and its qty is not decreased

- fix static

Author: mslabko

app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php

@@ -182,7 +182,6 @@ protected function _isManageStock()
      */
     protected function _getStockStatusSelect($entityIds = null, $usePrimaryTable = false)
     {
-        $metadata = $this->getMetadataPool()->getMetadata(\Magento\Catalog\Api\Data\ProductInterface::class);
         $connection = $this->getConnection();
         $qtyExpr = $connection->getCheckSql('cisi.qty > 0', 'cisi.qty', 0);
         $select = $connection->select()->from(
@@ -202,7 +201,7 @@ protected function _getStockStatusSelect($entityIds = null, $usePrimaryTable = f
         )->where(
             'cis.website_id = ?',
             $this->getStockConfiguration()->getDefaultScopeId()
-        )->where( 'e.type_id = ?', $this->getTypeId())
+        )->where('e.type_id = ?', $this->getTypeId())
             ->group(['e.entity_id', 'cis.website_id', 'cis.stock_id']);
 
         $select->columns(['status' => $this->getStatusExpression($connection, true)]);

app/code/Magento/CatalogInventory/Model/ResourceModel/Stock/Status.php

@@ -10,6 +10,7 @@
 
 /**
  * CatalogInventory Stock Status per website Resource Model
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Status extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb
 {

app/code/Magento/CatalogInventory/Test/Unit/Helper/StockTest.php

@@ -96,7 +96,7 @@ public function testAssignStatusToProduct()
             ->disableOriginalConstructor()
             ->setMethods(['setIsSalable', 'getId'])
             ->getMock();
-       $productMock->expects($this->once())
+        $productMock->expects($this->once())
             ->method('setIsSalable')
             ->with($status);
         $this->assertNull($this->stock->assignStatusToProduct($productMock));

app/code/Magento/CatalogSearch/Test/Unit/Model/Search/IndexBuilderTest.php

@@ -58,6 +58,10 @@ class IndexBuilderTest extends \PHPUnit_Framework_TestCase
      */
     private $scopeInterface;
 
+    /**
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @return void
+     */
     protected function setUp()
     {
         $this->select = $this->getMockBuilder('\Magento\Framework\DB\Select')
@@ -142,6 +146,9 @@ function ($left, $operator, $right) {
             '',
             false
         );
+        $this->stockConfiguration = $this
+            ->getMockBuilder('\Magento\CatalogInventory\Api\StockConfigurationInterface')
+            ->getMock();
 
         $objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
         $this->target = $objectManagerHelper->getObject(
@@ -156,14 +163,6 @@ function ($left, $operator, $right) {
                 'dimensionScopeResolver' => $this->dimensionScopeResolver
             ]
         );
-        $this->initStockConfiguration();
-    }
-
-    protected function initStockConfiguration()
-    {
-        $this->stockConfiguration = $this
-            ->getMockBuilder('\Magento\CatalogInventory\Api\StockConfigurationInterface')
-            ->getMock();
 
         // Todo: \Magento\Framework\TestFramework\Unit\Helper\ObjectManager to do this automatically (MAGETWO-49793)
         $reflection = new \ReflectionClass(get_class($this->target));