Skip to content

Commit 0d20774

Browse files
author
Robert He
committed
MAGETWO-51577: FAT failure on TaxCalculationTest for Downloadable and Configurable product
-- fixed FAT failures by removing sale rules and tax rules before running tests
1 parent e99eea7 commit 0d20774

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dev/tests/functional/tests/app/Magento/SalesRule/Test/TestStep/CreateSalesRuleStep.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ public function __construct(FixtureFactory $fixtureFactory, DeleteAllSalesRuleSt
5757
*/
5858
public function run()
5959
{
60-
$this->deleteAllSalesRule->run();
6160
$result['salesRule'] = null;
6261
if ($this->salesRule !== null) {
62+
$this->deleteAllSalesRule->run();
6363
$salesRule = $this->fixtureFactory->createByCode(
6464
'salesRule',
6565
['dataset' => $this->salesRule]

dev/tests/functional/tests/app/Magento/Tax/Test/TestStep/CreateTaxRuleStep.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ public function __construct(FixtureFactory $fixtureFactory, DeleteAllTaxRulesSte
5757
*/
5858
public function run()
5959
{
60-
$this->deleteAllTaxRule->run();
6160
$result['taxRule'] = null;
6261
if ($this->taxRule !== null) {
62+
$this->deleteAllTaxRule->run();
6363
$taxRuleDataSets = explode(',', $this->taxRule);
6464
foreach ($taxRuleDataSets as $taxRuleDataSet) {
6565
$taxRule = $this->fixtureFactory->createByCode(

0 commit comments

Comments
 (0)