ACP2E-23: [Magento Cloud] Error message in PDP disappearing quickly - Code refactoring applied.

Author: pradeep1819

app/code/Magento/Catalog/Model/Theme/CustomerData/MessageProvider.php renamed to app/code/Magento/Catalog/Model/Theme/CustomerData/MessagesProvider.php

@@ -14,7 +14,7 @@
 use Magento\Framework\Message\ManagerInterface as MessageManager;
 use Magento\Theme\CustomerData\MessagesProviderInterface;
 
-class MessageProvider implements MessagesProviderInterface
+class MessagesProvider implements MessagesProviderInterface
 {
     /**
      *
@@ -61,12 +61,7 @@ public function getMessages(): Collection
         $clearSessionMessages = true;
 
         if ((bool) $this->appConfig->getValue(Synchronizer::ALLOW_SYNC_WITH_BACKEND_PATH)) {
-
-            $forceNewSectionTimestamp = $this->request->getParam('force_new_section_timestamp') ?? null;
-
-            if ('true' !== $forceNewSectionTimestamp) {
-                $clearSessionMessages = false;
-            }
+            $clearSessionMessages = $this->request->getParam('force_new_section_timestamp') === 'true';
         }
 
         return $this->messageManager->getMessages($clearSessionMessages);

app/code/Magento/Catalog/etc/di.xml

@@ -76,7 +76,7 @@
     <preference for="Magento\Catalog\Api\Data\MassActionInterface" type="Magento\Catalog\Model\MassAction" />
     <preference for="Magento\Catalog\Model\ProductLink\Data\ListCriteriaInterface" type="Magento\Catalog\Model\ProductLink\Data\ListCriteria" />
     <preference for="Magento\Catalog\Api\CategoryListDeleteBySkuInterface" type="Magento\Catalog\Model\CategoryLinkRepository"/>
-    <preference for="Magento\Theme\CustomerData\MessagesProviderInterface" type="Magento\Catalog\Model\Theme\CustomerData\MessageProvider"/>
+    <preference for="Magento\Theme\CustomerData\MessagesProviderInterface" type="Magento\Catalog\Model\Theme\CustomerData\MessagesProvider"/>
     <type name="Magento\Customer\Model\ResourceModel\Visitor">
         <plugin name="catalogLog" type="Magento\Catalog\Model\Plugin\Log" />
     </type>

app/code/Magento/Theme/CustomerData/Messages.php

@@ -39,7 +39,7 @@ class Messages implements SectionSourceInterface
      *
      * @param MessageManager $messageManager
      * @param InterpretationStrategyInterface $interpretationStrategy
-     * @param MessagesProviderInterface $messageProvider
+     * @param MessagesProviderInterface|null $messageProvider
      */
     public function __construct(
         MessageManager $messageManager,

app/code/Magento/Theme/CustomerData/MessageProvider.php renamed to app/code/Magento/Theme/CustomerData/MessagesProvider.php

@@ -10,7 +10,7 @@
 use Magento\Framework\Message\Collection;
 use Magento\Framework\Message\ManagerInterface as MessageManager;
 
-class MessageProvider implements MessagesProviderInterface
+class MessagesProvider implements MessagesProviderInterface
 {
     /**
      * Manager messages

app/code/Magento/Theme/etc/di.xml

@@ -19,7 +19,7 @@
     <preference for="Magento\Framework\View\Model\PageLayout\Config\BuilderInterface" type="Magento\Theme\Model\PageLayout\Config\Builder"/>
     <preference for="Magento\Theme\Model\Design\Config\MetadataProviderInterface" type="Magento\Theme\Model\Design\Config\MetadataProvider"/>
     <preference for="Magento\Theme\Model\Theme\StoreThemesResolverInterface" type="Magento\Theme\Model\Theme\StoreThemesResolver"/>
-    <preference for="Magento\Theme\CustomerData\MessagesProviderInterface" type="Magento\Theme\CustomerData\MessageProvider"/>
+    <preference for="Magento\Theme\CustomerData\MessagesProviderInterface" type="Magento\Theme\CustomerData\MessagesProvider"/>
     <type name="Magento\Theme\Model\Config">
         <arguments>
             <argument name="configCache" xsi:type="object">Magento\Framework\App\Cache\Type\Config</argument>