correct criteria for skipping attribute options from the layered navigation

Diego Cabrejas · Diego Cabrejas · commit 0c6e4decd8ea · 2016-11-26T15:48:07.000Z
diff --git a/app/code/Magento/CatalogSearch/Model/Layer/Filter/Attribute.php b/app/code/Magento/CatalogSearch/Model/Layer/Filter/Attribute.php
@@ -53,7 +53,7 @@ public function __construct(
     public function apply(\Magento\Framework\App\RequestInterface $request)
     {
         $attributeValue = $request->getParam($this->_requestVar);
-        if (empty($attributeValue)) {
+        if (empty($attributeValue) && !is_numeric($attributeValue)) {
             return $this;
         }
         $attribute = $this->getAttributeModel();
@@ -95,7 +95,7 @@ protected function _getItemsData()
         $options = $attribute->getFrontend()
             ->getSelectOptions();
         foreach ($options as $option) {
-            if (empty($option['value'])) {
+            if (empty($option['value']) && !is_numeric($option['value'])) {
                 continue;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function __construct(`
`53`	`53`	`public function apply(\Magento\Framework\App\RequestInterface $request)`
`54`	`54`	`{`
`55`	`55`	`$attributeValue = $request->getParam($this->_requestVar);`
`56`		`- if (empty($attributeValue)) {`
	`56`	`+ if (empty($attributeValue) && !is_numeric($attributeValue)) {`
`57`	`57`	`return $this;`
`58`	`58`	`}`
`59`	`59`	`$attribute = $this->getAttributeModel();`
`@@ -95,7 +95,7 @@ protected function _getItemsData()`
`95`	`95`	`$options = $attribute->getFrontend()`
`96`	`96`	`->getSelectOptions();`
`97`	`97`	`foreach ($options as $option) {`
`98`		`- if (empty($option['value'])) {`
	`98`	`+ if (empty($option['value']) && !is_numeric($option['value'])) {`
`99`	`99`	`continue;`
`100`	`100`	`}`
`101`	`101`