MAGETWO-99035: Payflow Field format error: 10413-The totals of the cart item amounts do not match order amounts.

Author: dyushkin

app/code/Magento/Paypal/Model/Cart.php

@@ -9,6 +9,7 @@
 
 /**
  * PayPal-specific model for shopping cart items and totals
+ *
  * The main idea is to accommodate all possible totals into PayPal-compatible 4 totals and line items
  */
 class Cart extends \Magento\Payment\Model\Cart

app/code/Magento/Paypal/Model/Payflow/Transparent.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Paypal\Model\Payflow;
 
@@ -134,6 +135,8 @@ public function __construct(
     }
 
     /**
+     * Gets response validator instance.
+     *
      * @return ResponseValidator
      */
     public function getResponceValidator()
@@ -189,6 +192,7 @@ public function authorize(InfoInterface $payment, $amount)
 
         try {
             $this->responseValidator->validate($response, $this);
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
         } catch (LocalizedException $exception) {
             $payment->setParentTransactionId($response->getData(self::PNREF));
             $this->void($payment);
@@ -214,10 +218,12 @@ public function getConfigInterface()
     }
 
     /**
+     * Creates vault payment token.
+     *
      * @param Payment $payment
      * @param string $token
-     * @throws LocalizedException
      * @return void
+     * @throws \Exception
      */
     protected function createPaymentToken(Payment $payment, $token)
     {
@@ -236,8 +242,11 @@ protected function createPaymentToken(Payment $payment, $token)
     }
 
     /**
+     * Generates CC expiration date by year and month provided in payment.
+     *
      * @param Payment $payment
      * @return string
+     * @throws \Exception
      */
     private function getExpirationDate(Payment $payment)
     {
@@ -256,6 +265,8 @@ private function getExpirationDate(Payment $payment)
     }
 
     /**
+     * Returns payment extension attributes instance.
+     *
      * @param Payment $payment
      * @return \Magento\Sales\Api\Data\OrderPaymentExtensionInterface
      */

app/code/Magento/Paypal/Test/Unit/Model/CartTest.php

@@ -7,6 +7,9 @@
 
 use Magento\Paypal\Model\Cart;
 
+/**
+ * @see \Magento\Paypal\Model\Cart
+ */
 class CartTest extends \PHPUnit\Framework\TestCase
 {
     /**

app/code/Magento/Paypal/Test/Unit/Model/Payflow/TransparentTest.php

@@ -103,18 +103,22 @@ public function setUp()
     public function testValidAuthorizeRequest(DataObject $validAuthorizeRequest)
     {
         $this->scopeConfig->method('getValue')
-            ->willReturnMap([
-                ['payment/payflowpro/user', ScopeInterface::SCOPE_STORE, null, 'user'],
-                ['payment/payflowpro/vendor', ScopeInterface::SCOPE_STORE, null, 'vendor'],
-                ['payment/payflowpro/partner', ScopeInterface::SCOPE_STORE, null, 'partner'],
-                ['payment/payflowpro/pwd', ScopeInterface::SCOPE_STORE, null, 'pwd'],
-                ['payment/payflowpro/verbosity', ScopeInterface::SCOPE_STORE, null, 'verbosity'],
-            ]);
+            ->willReturnMap(
+                [
+                    ['payment/payflowpro/user', ScopeInterface::SCOPE_STORE, null, 'user'],
+                    ['payment/payflowpro/vendor', ScopeInterface::SCOPE_STORE, null, 'vendor'],
+                    ['payment/payflowpro/partner', ScopeInterface::SCOPE_STORE, null, 'partner'],
+                    ['payment/payflowpro/pwd', ScopeInterface::SCOPE_STORE, null, 'pwd'],
+                    ['payment/payflowpro/verbosity', ScopeInterface::SCOPE_STORE, null, 'verbosity'],
+                ]
+            );
         $this->paymentConfig->method('getBuildNotationCode')->willReturn('BUTTONSOURCE');
         $this->payment->method('getAdditionalInformation')
-            ->willReturnMap([
-                [Payflowpro::PNREF, 'XXXXXXXXXXXX'],
-            ]);
+            ->willReturnMap(
+                [
+                    [Payflowpro::PNREF, 'XXXXXXXXXXXX'],
+                ]
+            );
         $this->order->method('getIncrementId')->willReturn('000000001');
         $this->order->method('getBaseCurrencyCode')->willReturn('USD');
         $this->payPalCart->method('getSubtotal')->willReturn(5.00);
@@ -136,26 +140,28 @@ public function validAuthorizeRequestDataProvider(): array
     {
         return [
             [
-                new DataObject([
-                    'user' => 'user',
-                    'vendor' => 'vendor',
-                    'partner' => 'partner',
-                    'pwd' => 'pwd',
-                    'verbosity' => 'verbosity',
-                    'BUTTONSOURCE' => 'BUTTONSOURCE',
-                    'tender' => 'C',
-                    'custref' => '000000001',
-                    'invnum' => '000000001',
-                    'comment_1' => '000000001',
-                    'trxtype' => 'A',
-                    'origid' => 'XXXXXXXXXXXX',
-                    'amt' => '10.00',
-                    'currency' => 'USD',
-                    'itemamt' => '5.00',
-                    'taxamt' => '5.00',
-                    'freightamt' => '5.00',
-                    'discount' => '5.00',
-                ]),
+                new DataObject(
+                    [
+                        'user' => 'user',
+                        'vendor' => 'vendor',
+                        'partner' => 'partner',
+                        'pwd' => 'pwd',
+                        'verbosity' => 'verbosity',
+                        'BUTTONSOURCE' => 'BUTTONSOURCE',
+                        'tender' => 'C',
+                        'custref' => '000000001',
+                        'invnum' => '000000001',
+                        'comment1' => '000000001',
+                        'trxtype' => 'A',
+                        'origid' => 'XXXXXXXXXXXX',
+                        'amt' => '10.00',
+                        'currency' => 'USD',
+                        'itemamt' => '5.00',
+                        'taxamt' => '5.00',
+                        'freightamt' => '5.00',
+                        'discount' => '5.00',
+                    ]
+                ),
             ]
         ];
     }