ENGCOM-6689: #26065 isSaleable cache and optimize result for configurable products #26071

Author: slavvka

app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php

@@ -102,6 +102,13 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
      */
     protected $_canConfigure = true;
 
+    /**
+     * Local cache
+     *
+     * @var array
+     */
+    protected $isSaleableBySku = [];
+
     /**
      * @var \Magento\Framework\App\Config\ScopeConfigInterface
      */
@@ -585,7 +592,7 @@ protected function getGalleryReadHandler()
      * @param  \Magento\Catalog\Model\Product $product
      * @return \Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable\Product\Collection
      */
-    public function getUsedProductCollection($product)
+    protected function getLinkedProductCollection($product)
     {
         $collection = $this->_productCollectionFactory->create()->setFlag(
             'product_children',
@@ -600,6 +607,17 @@ public function getUsedProductCollection($product)
         return $collection;
     }
 
+    /**
+     * Retrieve related products collection. Extension point for listing
+     *
+     * @param  \Magento\Catalog\Model\Product $product
+     * @return \Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable\Product\Collection
+     */
+    public function getUsedProductCollection($product)
+    {
+        return $this->getLinkedProductCollection($product);
+    }
+
     /**
      * Before save process
      *
@@ -744,15 +762,27 @@ private function saveRelatedProducts(ProductInterface $product)
      */
     public function isSalable($product)
     {
+        $storeId = $this->getStoreFilter($product);
+        if ($storeId instanceof \Magento\Store\Model\Store) {
+            $storeId = $storeId->getId();
+        }
+
+        $sku = $product->getSku();
+        if (isset($this->isSaleableBySku[$storeId][$sku])) {
+            return $this->isSaleableBySku[$storeId][$sku];
+        }
+
         $salable = parent::isSalable($product);
 
         if ($salable !== false) {
-            $collection = $this->getUsedProductCollection($product);
-            $collection->addStoreFilter($this->getStoreFilter($product));
+            $collection = $this->getLinkedProductCollection($product);
+            $collection->addStoreFilter($storeId);
             $collection = $this->salableProcessor->process($collection);
             $salable = 0 !== $collection->getSize();
         }
 
+        $this->isSaleableBySku[$storeId][$sku] = $salable;
+
         return $salable;
     }
 

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/Type/ConfigurableTest.php

@@ -567,12 +567,18 @@ public function testHasOptionsFalse()
     public function testIsSalable()
     {
         $productMock = $this->getMockBuilder(\Magento\Catalog\Model\Product::class)
-            ->setMethods(['__wakeup', 'getStatus', 'hasData', 'getData', 'getStoreId', 'setData'])
+            ->setMethods(['__wakeup', 'getStatus', 'hasData', 'getData', 'getStoreId', 'setData', 'getSku'])
             ->disableOriginalConstructor()
             ->getMock();
+        $productMock
+            ->expects($this->at(0))
+            ->method('getData')
+            ->with('_cache_instance_store_filter')
+            ->willReturn(0);
         $productMock->expects($this->once())->method('getStatus')->willReturn(1);
         $productMock->expects($this->any())->method('hasData')->willReturn(true);
-        $productMock->expects($this->at(2))->method('getData')->with('is_salable')->willReturn(true);
+        $productMock->expects($this->at(1))->method('getSku')->willReturn('SKU-CODE');
+        $productMock->expects($this->at(4))->method('getData')->with('is_salable')->willReturn(true);
         $productCollection = $this->getMockBuilder(
             \Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable\Product\Collection::class
         )