MAGETWO-91771: Comma special character in cart price rule condition value results in incorrect rule

Author: Sergey Shvets

app/code/Magento/ConfigurableProduct/Test/Unit/Block/Product/View/Type/ConfigurableTest.php

@@ -84,6 +84,9 @@ class ConfigurableTest extends \PHPUnit\Framework\TestCase
      */
     private $variationPricesMock;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         $this->mockContextObject();
@@ -346,13 +349,13 @@ public function testGetJsonConfig()
     /**
      * Retrieve array with expected parameters for method getJsonConfig()
      *
-     * @param $productId
-     * @param $amount
-     * @param $priceQty
-     * @param $percentage
+     * @param int $productId
+     * @param double $amount
+     * @param int $priceQty
+     * @param int $percentage
      * @return array
      */
-    private function getExpectedArray($productId, $amount, $priceQty, $percentage)
+    private function getExpectedArray($productId, $amount, $priceQty, $percentage): array
     {
         $expectedArray = [
             'attributes' => [],

app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/ProductTest.php

@@ -207,7 +207,10 @@ public function testGetValueElementChooserUrl($attribute, $url, $jsObject = '')
         $this->assertEquals($url, $this->model->getValueElementChooserUrl());
     }
 
-    public function testValidateCategoriesIgnoresVisibility()
+    /**
+     * test ValidateCategoriesIgnoresVisibility
+     */
+    public function testValidateCategoriesIgnoresVisibility(): void
     {
         /* @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
         $product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class)

lib/internal/Magento/Framework/Locale/Test/Unit/FormatTest.php

@@ -33,6 +33,9 @@ class FormatTest extends \PHPUnit\Framework\TestCase
      */
     protected $currency;
 
+    /**
+     * {@inheritDoc}
+     */
     protected function setUp()
     {
         $this->currency = $this->getMockBuilder(\Magento\Directory\Model\Currency::class)
@@ -64,11 +67,11 @@ protected function setUp()
     }
 
     /**
-     * @param $localeCode
-     * @param $expectedResult
+     * @param string $localeCode
+     * @param array $expectedResult
      * @dataProvider getPriceFormatDataProvider
      */
-    public function testGetPriceFormat($localeCode, $expectedResult)
+    public function testGetPriceFormat($localeCode, array $expectedResult): void
     {
         $this->scope->expects($this->once())
             ->method('getCurrentCurrency')
@@ -80,9 +83,10 @@ public function testGetPriceFormat($localeCode, $expectedResult)
     }
 
     /**
+     *
      * @return array
      */
-    public function getPriceFormatDataProvider()
+    public function getPriceFormatDataProvider(): array
     {
         return [
             ['en_US', ['decimalSymbol' => '.', 'groupSymbol' => ',']],
@@ -93,16 +97,18 @@ public function getPriceFormatDataProvider()
     }
 
     /**
-     * @param float | null $expected
-     * @param string|float|int $value
+     *
+     * @param        mixed $value
+     * @param        float $expected
      * @dataProvider provideNumbers
      */
-    public function testGetNumber($value, $expected)
+    public function testGetNumber($value, $expected): void
     {
         $this->assertEquals($expected, $this->formatModel->getNumber($value));
     }
 
     /**
+     *
      * @return array
      */
     public function provideNumbers(): array