Skip to content

Commit 0bfad6b

Browse files
shanthishanthi
authored andcommitted
Updated review comments
1 parent 3ebb5d9 commit 0bfad6b

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

app/code/Magento/Paypal/Test/Mftf/Test/VoidASalesOrderPlacedWithPayPalPaymentsProTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@
7474
<waitForText selector="{{AdminOrderCommentsTabSection.authorizationNotes('Voided')}}" userInput="$getVoidAuthorizationNotesWithID" stepKey="seeOrderHistoryNotes"/>
7575
<!-- Check the last transaction of the order and validate the details for Void and Authorization-->
7676
<actionGroup ref="AdminViewTransactionsInOrderActionGroup" stepKey="validateVoidTransaction"/>
77-
<waitForText selector="{{AdminTransactionsGridSection.transactionData('Is Closed')}}" userInput="Yes" stepKey="seeIfClosedHeaderIsYesForVoid"/>
77+
<waitForText selector="{{AdminTransactionsGridSection.transactionData('Is Closed')}}" userInput="Yes" stepKey="seeIfClosedHeaderIsSetAsYesForVoid"/>
7878
<waitForElementClickable selector="{{AdminProductFormActionSection.backButton}}" stepKey="waitForBackButtonToBeClicked"/>
7979
<click selector="{{AdminProductFormActionSection.backButton}}" stepKey="clickBackButton"/>
8080
<actionGroup ref="AdminViewAuthorizationTransactionsInOrderActionGroup" stepKey="validateAuthTransaction"/>
81-
<waitForText selector="{{AdminTransactionsGridSection.transactionData('Is Closed')}}" userInput="Yes" stepKey="seeIfClosedHeaderIsYesForAuthorization"/>
81+
<waitForText selector="{{AdminTransactionsGridSection.transactionData('Is Closed')}}" userInput="Yes" stepKey="seeIfClosedHeaderIsSetAsYesForAuthorization"/>
8282
</test>
8383
</tests>

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminViewTransactionsInOrderActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<waitForElementClickable selector="{{AdminTransactionsGridSection.orderTxnTableFirstRow}}" stepKey="clickOnVoidTransaction"/>
2222
<click selector="{{AdminTransactionsGridSection.orderTxnTableFirstRow}}" stepKey="clickVoidTxn"/>
2323
<waitForPageLoad stepKey="waitForTxnToLoad"/>
24-
<grabTextFrom selector="{{AdminTransactionsGridSection.transactionId}}" stepKey="getVoidTransaction"/>
24+
<grabTextFrom selector="{{AdminTransactionsGridSection.transactionData('Transaction ID')}}" stepKey="getVoidTransaction"/>
2525
<assertRegExp stepKey="assertEquals" message="pass">
2626
<expectedResult type="string">/([0-9a-z\-])*(?&lt;!void)$/</expectedResult>
2727
<actualResult type="variable">getVoidTransaction</actualResult>

app/code/Magento/Sales/Test/Mftf/Section/AdminTransactionsGridSection.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
<element name="transactionsSectionBtn" type="button" selector="#sales_order_view_tabs_order_transactions" />
1313
<element name="orderTxnTable" type="text" selector="#order_transactions"/>
1414
<element name="orderTxnTableFirstRow" type="text" selector=".col-id.col-transaction_id.col-number" />
15-
<element name="transactionId" type="text" selector="#log_details_fieldset > table > tbody > tr:nth-child(1) > td" />
1615
<element name="orderTxnTableTypeFilter" type="button" selector="#order_transactions_filter_txn_type"/>
1716
<element name="orderTxnTableSearchBtn" type="button" selector="#container button[title='Search']" />
18-
<element name="transactionData" type="text" selector="//th[contains(text(),'{{transactionData}}')]/following-sibling::td" parameterized="true"/>
17+
<element name="transactionData" type="text" selector="//th[text()='{{transactionData}}']/following-sibling::td" parameterized="true"/>
1918
</section>
2019
</sections>

0 commit comments

Comments
 (0)