Fixed the static tests & feedbacks

Author: srsathish92

app/code/Magento/Catalog/Test/Unit/ViewModel/Product/Checker/AddToCompareAvailabilityTest.php

@@ -26,29 +26,26 @@ class AddToCompareAvailabilityTest extends \PHPUnit\Framework\TestCase
     private $viewModel;
 
     /**
-     * @var StockConfigurationInterface|MockObject 
+     * @var StockConfigurationInterface|MockObject
      */
-    protected $stockConfiguration;
-
-    /**
-     * @var ObjectManager
-     */
-    private $objectManager;
+    protected $stockConfigurationMock;
 
     /**
      * @inheritdoc
      */
     protected function setUp(): void
     {
 
-        $this->stockConfiguration =
+        $objectManager = new ObjectManager($this);
+
+        $this->stockConfigurationMock =
             $this->getMockBuilder(StockConfigurationInterface::class)
             ->getMock();
 
-        $this->viewModel = $this->getObjectManager()->getObject(
+        $this->viewModel = $objectManager->getObject(
             AddToCompareAvailability::class,
             [
-                'stockConfiguration' => $this->stockConfiguration
+                'stockConfiguration' => $this->stockConfigurationMock
             ]
         );
     }
@@ -81,7 +78,7 @@ public function testIsAvailableForCompare($status, $isSalable, $isInStock, $isSh
             ->method('getQuantityAndStockStatus')
             ->willReturn($isInStock);
 
-        $this->stockConfiguration->expects($this->any())
+        $this->stockConfigurationMock->expects($this->any())
             ->method('isShowOutOfStock')
             ->willReturn($isShowOutOfStock);
 
@@ -90,7 +87,7 @@ public function testIsAvailableForCompare($status, $isSalable, $isInStock, $isSh
 
     /**
      * Data provider for isAvailableForCompare()
-     * 
+     *
      * @return array
      */
     public function isAvailableForCompareDataProvider(): array
@@ -103,16 +100,4 @@ public function isAvailableForCompareDataProvider(): array
             [2, true, ['is_in_stock' => true], false]
         ];
     }
-
-    /**
-     * @return ObjectManager
-     */
-    private function getObjectManager(): ObjectManager
-    {
-        if (null === $this->objectManager) {
-            $this->objectManager = new ObjectManager($this);
-        }
-
-        return $this->objectManager;
-    }
 }