Skip to content

Commit 0b4ce27

Browse files
committed
AC-2461: Implement email and newsletter template compatibility CLI check.
1 parent 5066da8 commit 0b4ce27

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

app/code/Magento/Email/Console/Command/DatabaseTemplateCompatibilityCommand.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,13 @@ class DatabaseTemplateCompatibilityCommand extends Command
3535
*/
3636
protected bool $hasErrors = false;
3737

38+
/**
39+
* Constructor
40+
*
41+
* @param VariableCompatibilityChecker $compatibilityChecker
42+
* @param CollectionFactory $templateCollection
43+
* @param string $name
44+
*/
3845
public function __construct(
3946
VariableCompatibilityChecker $compatibilityChecker,
4047
CollectionFactory $templateCollection,

app/code/Magento/Email/Model/Template/VariableCompatibilityChecker.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ class VariableCompatibilityChecker
3535
*/
3636
private Parameter $parameterTokenizer;
3737

38+
/**
39+
* Constructor
40+
*
41+
* @param Variable $variableTokenizer
42+
* @param Parameter $parameterTokenizer
43+
*/
3844
public function __construct(Variable $variableTokenizer, Parameter $parameterTokenizer)
3945
{
4046
$this->variableTokenizer = $variableTokenizer;
@@ -44,6 +50,7 @@ public function __construct(Variable $variableTokenizer, Parameter $parameterTok
4450
/**
4551
* Detect invalid usage of template filter directives
4652
*
53+
* @param string $template
4754
*/
4855
public function getCompatibilityIssues(string $template): array
4956
{

dev/tests/integration/testsuite/Magento/Email/Model/Template/VariableCompatibilityCheckerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ public function testCompatibilityCheck()
2020
$checker = $objectManager->get(VariableCompatibilityChecker::class);
2121
$errors = $checker->getCompatibilityIssues(file_get_contents(__DIR__ . '/../_files/variables_template.html'));
2222

23-
self::assertCount(20, $errors);
23+
self::assertCount(17, $errors);
2424
}
2525
}

0 commit comments

Comments
 (0)