Merge pull request #2220 from magento-qwerty/PR-13032018

[Qwerty] March bugfixes

Author: viktym

.htaccess

@@ -355,6 +355,15 @@
             Require all denied
         </IfVersion>
     </Files>
+    <Files auth.json>
+        <IfVersion < 2.4>
+            order allow,deny
+            deny from all
+        </IfVersion>
+        <IfVersion >= 2.4>
+            Require all denied
+        </IfVersion>
+    </Files>
 
 # For 404s and 403s that aren't handled by the application, show plain 404 response
 ErrorDocument 404 /pub/errors/404.php

.htaccess.sample

@@ -332,6 +332,15 @@
             Require all denied
         </IfVersion>
     </Files>
+    <Files auth.json>
+        <IfVersion < 2.4>
+            order allow,deny
+            deny from all
+        </IfVersion>
+        <IfVersion >= 2.4>
+            Require all denied
+        </IfVersion>
+    </Files>
 
 # For 404s and 403s that aren't handled by the application, show plain 404 response
 ErrorDocument 404 /pub/errors/404.php

app/code/Magento/Bundle/Model/OptionRepository.php

@@ -201,10 +201,10 @@ public function save(
 
         /** @var \Magento\Bundle\Model\Option $existingOption */
         $existingOption = $optionCollection->getFirstItem();
-        if (!$optionId) {
-            $option->setOptionId(null);
-        }
         if (!$optionId || $existingOption->getParentId() != $parentId) {
+            //If option ID is empty or existing option's parent ID is different
+            //we'd need a new ID for the option.
+            $option->setOptionId(null);
             $option->setDefaultTitle($option->getTitle());
             if (is_array($option->getProductLinks())) {
                 $linksToAdd = $option->getProductLinks();

app/code/Magento/Bundle/Model/Product/SaveHandler.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Bundle\Model\Product;
 
+use Magento\Bundle\Api\Data\OptionInterface;
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Bundle\Api\ProductOptionRepositoryInterface as OptionRepository;
 use Magento\Bundle\Api\ProductLinkManagementInterface;
@@ -49,42 +50,58 @@ public function __construct(
             ?: ObjectManager::getInstance()->get(MetadataPool::class);
     }
 
+    /**
+     * @param ProductInterface $bundle
+     * @param OptionInterface[] $currentOptions
+     *
+     * @return void
+     */
+    private function removeOldOptions(
+        ProductInterface $bundle,
+        array $currentOptions
+    ) {
+        $oldOptions = $this->optionRepository->getList($bundle->getSku());
+        if ($oldOptions) {
+            $remainingOptions = [];
+            $metadata
+                = $this->metadataPool->getMetadata(ProductInterface::class);
+            $productId = $bundle->getData($metadata->getLinkField());
+
+            foreach ($currentOptions as $option) {
+                $remainingOptions[] = $option->getOptionId();
+            }
+            foreach ($oldOptions as $option) {
+                if (!in_array($option->getOptionId(), $remainingOptions)) {
+                    $option->setParentId($productId);
+                    $this->removeOptionLinks($bundle->getSku(), $option);
+                    $this->optionRepository->delete($option);
+                }
+            }
+        }
+    }
+
     /**
      * @param object $entity
      * @param array $arguments
-     * @return \Magento\Catalog\Api\Data\ProductInterface|object
+     *
+     * @return ProductInterface|object
+     *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function execute($entity, $arguments = [])
     {
         /** @var \Magento\Bundle\Api\Data\OptionInterface[] $options */
         $options = $entity->getExtensionAttributes()->getBundleProductOptions() ?: [];
-
+        //Only processing bundle products.
         if ($entity->getTypeId() !== 'bundle' || empty($options)) {
             return $entity;
         }
-
+        /** @var ProductInterface $entity */
+        //Removing old options
         if (!$entity->getCopyFromView()) {
-            $updatedOptions = [];
-            $oldOptions = $this->optionRepository->getList($entity->getSku());
-
-            $metadata = $this->metadataPool->getMetadata(ProductInterface::class);
-
-            $productId = $entity->getData($metadata->getLinkField());
-
-            foreach ($options as $option) {
-                $updatedOptions[$option->getOptionId()][$productId] = (bool)$option->getOptionId();
-            }
-
-            foreach ($oldOptions as $option) {
-                if (!isset($updatedOptions[$option->getOptionId()][$productId])) {
-                    $option->setParentId($productId);
-                    $this->removeOptionLinks($entity->getSku(), $option);
-                    $this->optionRepository->delete($option);
-                }
-            }
+            $this->removeOldOptions($entity, $options);
         }
-
+        //Saving active options.
         foreach ($options as $option) {
             $this->optionRepository->save($entity, $option);
         }

app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/Full.php

@@ -87,13 +87,29 @@ public function __construct(
         $this->activeTableSwitcher = $activeTableSwitcher ?: $objectManager->get(ActiveTableSwitcher::class);
     }
 
+    /**
+     *
+     * Clear the table we'll be writing de-normalized data into
+     * to prevent archived data getting in the way of actual data.
+     *
+     * @return void
+     */
+    private function clearCurrentTable()
+    {
+        $this->connection->delete(
+            $this->activeTableSwitcher
+                ->getAdditionalTableName($this->getMainTable())
+        );
+    }
+
     /**
      * Refresh entities index
      *
      * @return $this
      */
     public function execute()
     {
+        $this->clearCurrentTable();
         $this->reindex();
         $this->activeTableSwitcher->switchTable($this->connection, [$this->getMainTable()]);
         return $this;
@@ -103,6 +119,9 @@ public function execute()
      * Return select for remove unnecessary data
      *
      * @return \Magento\Framework\DB\Select
+     *
+     * @deprecated Not used anymore.
+     * @see clearCurrentTable()
      */
     protected function getSelectUnnecessaryData()
     {
@@ -127,12 +146,14 @@ protected function getSelectUnnecessaryData()
      * Remove unnecessary data
      *
      * @return void
+     *
+     * @deprecated Not used anymore.
+     * @see clearCurrentTable()
      */
     protected function removeUnnecessaryData()
     {
-        $this->connection->query(
-            $this->connection->deleteFromSelect($this->getSelectUnnecessaryData(), $this->getMainTable())
-        );
+        //Called for backward compatibility.
+        $this->getSelectUnnecessaryData();
     }
 
     /**
@@ -233,6 +254,7 @@ private function reindexCategoriesBySelect(\Magento\Framework\DB\Select $basicSe
                 )
             );
             $this->publishData();
+            //Called for backward compatibility.
             $this->removeUnnecessaryData();
         }
     }