magento-engcom/magento2ce#2237: Fixed static tests failures

Author: Stanislav Idolov

app/code/Magento/Catalog/Model/ResourceModel/Eav/Attribute.php

@@ -167,6 +167,8 @@ public function __construct(
     }
 
     /**
+     * Init model
+     *
      * @return void
      */
     protected function _construct()
@@ -362,6 +364,7 @@ public function getStoreId()
 
     /**
      * Retrieve apply to products array
+     *
      * Return empty array if applied to all products
      *
      * @return string[]
@@ -507,128 +510,128 @@ public function getIndexType()
     }
 
     /**
+     * @inheritdoc
      * @codeCoverageIgnoreStart
-     * {@inheritdoc}
      */
     public function getIsWysiwygEnabled()
     {
         return $this->_getData(self::IS_WYSIWYG_ENABLED);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsHtmlAllowedOnFront()
     {
         return $this->_getData(self::IS_HTML_ALLOWED_ON_FRONT);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getUsedForSortBy()
     {
         return $this->_getData(self::USED_FOR_SORT_BY);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsFilterable()
     {
         return $this->_getData(self::IS_FILTERABLE);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsFilterableInSearch()
     {
         return $this->_getData(self::IS_FILTERABLE_IN_SEARCH);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsUsedInGrid()
     {
         return (bool)$this->_getData(self::IS_USED_IN_GRID);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsVisibleInGrid()
     {
         return (bool)$this->_getData(self::IS_VISIBLE_IN_GRID);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsFilterableInGrid()
     {
         return (bool)$this->_getData(self::IS_FILTERABLE_IN_GRID);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getPosition()
     {
         return $this->_getData(self::POSITION);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsSearchable()
     {
         return $this->_getData(self::IS_SEARCHABLE);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsVisibleInAdvancedSearch()
     {
         return $this->_getData(self::IS_VISIBLE_IN_ADVANCED_SEARCH);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsComparable()
     {
         return $this->_getData(self::IS_COMPARABLE);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsUsedForPromoRules()
     {
         return $this->_getData(self::IS_USED_FOR_PROMO_RULES);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsVisibleOnFront()
     {
         return $this->_getData(self::IS_VISIBLE_ON_FRONT);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getUsedInProductListing()
     {
         return $this->_getData(self::USED_IN_PRODUCT_LISTING);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getIsVisible()
     {
@@ -638,7 +641,7 @@ public function getIsVisible()
     //@codeCoverageIgnoreEnd
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getScope()
     {
@@ -720,7 +723,7 @@ public function setPosition($position)
     /**
      * Set apply to value for the element
      *
-     * @param string []|string
+     * @param string[]|string $applyTo
      * @return $this
      */
     public function setApplyTo($applyTo)
@@ -829,7 +832,7 @@ public function setScope($scope)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function afterDelete()
     {

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Eav/Source.php

@@ -330,6 +330,8 @@ public function getIdxTable($table = null)
     }
 
     /**
+     * Save data from select
+     *
      * @param \Magento\Framework\DB\Select $select
      * @param array $options
      * @return void

app/code/Magento/Catalog/Model/ResourceModel/Product/Option/Value.php

@@ -85,6 +85,7 @@ protected function _construct()
 
     /**
      * Proceed operations after object is saved
+     *
      * Save options store data
      *
      * @param AbstractModel $object

app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Widget/CategoriesJson.php

@@ -1,6 +1,5 @@
 <?php
 /**
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
@@ -9,8 +8,12 @@
 use Magento\Backend\App\Action\Context;
 use Magento\Catalog\Model\Category;
 use Magento\Framework\Registry;
+use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
 
-class CategoriesJson extends \Magento\CatalogRule\Controller\Adminhtml\Promo\Widget
+/**
+ * Categories json widget for catalog rule
+ */
+class CategoriesJson extends \Magento\CatalogRule\Controller\Adminhtml\Promo\Widget implements HttpPostActionInterface
 {
     /**
      * Core registry

app/code/Magento/CurrencySymbol/Model/System/Currencysymbol.php

@@ -187,7 +187,7 @@ public function getCurrencySymbolsData()
     /**
      * Save currency symbol to config
      *
-     * @param  $symbols array
+     * @param array $symbols
      * @return $this
      */
     public function setCurrencySymbolsData($symbols = [])

app/code/Magento/LayeredNavigation/Observer/Edit/Tab/Front/ProductAttributeFormBuildFrontTabObserver.php

@@ -11,6 +11,9 @@
 use Magento\Framework\Module\Manager;
 use Magento\Framework\Event\ObserverInterface;
 
+/**
+ * Observer for Product Attribute Form
+ */
 class ProductAttributeFormBuildFrontTabObserver implements ObserverInterface
 {
     /**
@@ -34,6 +37,8 @@ public function __construct(Manager $moduleManager, Source\Yesno $optionList)
     }
 
     /**
+     * Execute
+     *
      * @param \Magento\Framework\Event\Observer $observer
      * @return void
      */

app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate/RateQuery.php

@@ -6,6 +6,9 @@
 
 namespace Magento\OfflineShipping\Model\ResourceModel\Carrier\Tablerate;
 
+/**
+ * Query builder for table rate
+ */
 class RateQuery
 {
     /**
@@ -24,6 +27,8 @@ public function __construct(
     }
 
     /**
+     * Prepare select
+     *
      * @param \Magento\Framework\DB\Select $select
      * @return \Magento\Framework\DB\Select
      */
@@ -77,6 +82,8 @@ public function prepareSelect(\Magento\Framework\DB\Select $select)
     }
 
     /**
+     * Returns query bindings
+     *
      * @return array
      */
     public function getBindings()
@@ -108,6 +115,8 @@ public function getBindings()
     }
 
     /**
+     * Returns rate request
+     *
      * @return \Magento\Quote\Model\Quote\Address\RateRequest
      */
     public function getRequest()
@@ -116,8 +125,8 @@ public function getRequest()
     }
 
     /**
-     * Returns the entire postcode if it contains no dash
-     * or the part of it prior to the dash in the other case
+     * Returns the entire postcode if it contains no dash or the part of it prior to the dash in the other case
+     *
      * @return string
      */
     private function getDestPostcodePrefix()

app/design/adminhtml/Magento/backend/web/css/source/forms/_fields.less

@@ -59,7 +59,11 @@
 }
 
 .abs-field-no-label {
+    /**
+     *@codingStandardsIgnoreStart
+     */
     #mix-grid .return_length(@field-label-grid__column, @field-grid__columns, '+');
+    //@codingStandardsIgnoreEnd
     margin-left: @_length;
 }