MC-17405: Add resolver for Pay Flow Pro support

- added fixes for review comments

Author: avattam06

app/code/Magento/Paypal/Controller/Transparent/Response.php

@@ -21,6 +21,7 @@
 use Magento\Framework\Session\Generic as Session;
 
 /**
+ * Class for requesting the response result form the paypal controller.
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Response extends \Magento\Framework\App\Action\Action implements CsrfAwareActionInterface
@@ -112,6 +113,8 @@ public function validateForCsrf(RequestInterface $request): ?bool
     }
 
     /**
+     * Exceute svaes the payment in quote and sends the resultInterface
+     *
      * @return ResultInterface
      */
     public function execute()

app/code/Magento/Paypal/Model/Payflow/Service/Request/SecureToken.php

@@ -16,7 +16,7 @@
 use Magento\Quote\Model\Quote;
 
 /**
- * Class SecureToken for setting, posting and returning a response DataObject for RequestSecureToken controller.
+ * Class for requesting a secure Payflow Pro token from Paypal
  */
 class SecureToken
 {
@@ -59,7 +59,7 @@ public function __construct(
      * @return DataObject
      * @throws \Exception
      */
-    public function requestToken(Quote $quote, $urls = [])
+    public function requestToken(Quote $quote, array $urls = [])
     {
         $this->transparent->setStore($quote->getStoreId());
         $request = $this->transparent->buildBasicRequest();

app/code/Magento/PaypalGraphQl/Model/Resolver/PayflowProToken.php

@@ -62,7 +62,7 @@ public function resolve(
         array $args = null
     ) {
         $cartId = $args['input']['cart_id'] ?? '';
-        $urls = $args['input']['urls'] ?? '';
+        $urls = $args['input']['urls'] ?? null ;
 
         $customerId = $context->getUserId();
         $cart = $this->getCartForUser->execute($cartId, $customerId);

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Customer/PlaceOrderWithPayflowProTest.php

@@ -17,7 +17,7 @@
 use Magento\Framework\Webapi\Request;
 
 /**
- * Test ExpressSetPaymentMethodTest graphql endpoint for customer
+ * End to end place order test using payflowpro via graphql endpoint for customer
  *
  * @magentoAppArea graphql
  */

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PaypalPayflowProSetPaymentMethodTest.php

@@ -8,7 +8,6 @@
 namespace Magento\PaypalGraphQl\Model\Resolver\Guest;
 
 use Magento\Framework\App\Request\Http;
-use Magento\Paypal\Model\Api\Nvp;
 use Magento\PaypalGraphQl\PaypalPayflowProAbstractTest;
 use Magento\Framework\Serialize\SerializerInterface;
 use Magento\Quote\Model\QuoteIdToMaskedQuoteId;