Skip to content

Commit 09692bc

Browse files
ENGCOM-3449: [Forwardport] Fix/add expresion #19180
- Merge Pull Request #19180 from torhoehn/magento2:2.3-develop-PR-port-17915 - Merged commits: 1. e697698 2. 3050d23 3. 99ea195
2 parents 5f976fa + 99ea195 commit 09692bc

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

lib/internal/Magento/Framework/Model/ResourceModel/Db/Collection/AbstractCollection.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,9 @@ public function addExpressionFieldToSelect($alias, $expression, $fields)
346346
$fullExpression = str_replace('{{' . $fieldKey . '}}', $fieldItem, $fullExpression);
347347
}
348348

349-
$this->getSelect()->columns([$alias => $fullExpression]);
349+
$fullExpression = new \Zend_Db_Expr($fullExpression);
350+
$this->_fieldsToSelect[$alias] = $fullExpression;
351+
$this->_fieldsToSelectChanged = true;
350352

351353
return $this;
352354
}

lib/internal/Magento/Framework/Model/Test/Unit/ResourceModel/Db/Collection/AbstractCollectionTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,9 @@ public function addFieldToSelectDataProvider()
269269
*/
270270
public function testAddExpressionFieldToSelect($alias, $expression, $fields, $expected)
271271
{
272-
$this->selectMock->expects($this->once())->method('columns')->with($expected);
273272
$this->assertTrue($this->uut->addExpressionFieldToSelect($alias, $expression, $fields) instanceof Uut);
273+
$this->assertEquals($expected, $this->uut->getFieldsToSelect());
274+
$this->assertTrue($this->uut->wereFieldsToSelectChanged());
274275
}
275276

276277
/**

0 commit comments

Comments
 (0)