Skip to content

Commit 093036f

Browse files
author
Joan He
committed
MAGETWO-66318: Remove usages of serialize/unserialize in CmsSampleData
- fix static test failurs
1 parent 11f9a2b commit 093036f

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

app/code/Magento/Cms/Setup/ContentConverter.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ class ContentConverter extends SerializedToJson
2222
private $parameterFactory;
2323

2424
/**
25-
* Constructor
25+
* ContentConverter constructor
2626
*
2727
* @param Serialize $serialize
2828
* @param Json $json
29+
* @param \Magento\Framework\Filter\Template\Tokenizer\ParameterFactory $parameterFactory
2930
*/
3031
public function __construct(
3132
Serialize $serialize,

app/code/Magento/Cms/Setup/UpgradeData.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ private function createPage()
130130
* Upgrade data to version 2.0.1,
131131
*
132132
* @return void
133+
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
133134
*/
134135
private function upgradeVersionTwoZeroOne()
135136
{

dev/tests/integration/testsuite/Magento/Cms/Setup/ContentConverterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ class ContentConverterTest extends \Magento\TestFramework\TestCase\AbstractContr
1313
protected function setUp()
1414
{
1515
$this->converter = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
16-
\Magento\Cms\Setup\ContentConverter::class);
16+
\Magento\Cms\Setup\ContentConverter::class
17+
);
1718
}
1819

1920
/**

dev/tests/integration/testsuite/Magento/Widget/Setup/LayoutUpdateConverterTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
* Copyright © 2013-2017 Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
namespace Magento\Cms\Setup;
7-
8-
use Magento\Widget\Setup\LayoutUpdateConverter;
6+
namespace Magento\Widget\Setup;
97

108
class LayoutUpdateConverterTest extends \Magento\TestFramework\TestCase\AbstractController
119
{
@@ -15,7 +13,8 @@ class LayoutUpdateConverterTest extends \Magento\TestFramework\TestCase\Abstract
1513
protected function setUp()
1614
{
1715
$this->converter = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
18-
LayoutUpdateConverter::class);
16+
LayoutUpdateConverter::class
17+
);
1918
}
2019

2120
/**

0 commit comments

Comments
 (0)