magento2-login-as-customer/issues/90: Static tests fix.

Author: engcom-Foxtrot

app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php

@@ -100,7 +100,7 @@ public function execute(): ResultInterface
 
         $customerStoreId = $request->getParam('store_id');
 
-        if (!isset($customerStoreId) && $this->config->getStoreViewLogin()) {
+        if (!isset($customerStoreId) && $this->config->isManualChoiceEnabled()) {
             $this->messageManager->addNoticeMessage(__('Please select a Store View to login in.'));
             return $resultRedirect->setPath('loginascustomer/login/manual', ['entity_id' => $customerId ]);
         }

app/code/Magento/LoginAsCustomer/Model/Config.php

@@ -8,19 +8,19 @@
 namespace Magento\LoginAsCustomer\Model;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
-use Magento\Store\Model\ScopeInterface;
 use Magento\Framework\App\ProductMetadataInterface;
+use Magento\Store\Model\ScopeInterface;
 
 /**
- * Class Config
+ * LoginAsCustomer module config model.
  */
 class Config
 {
     /**
      * Extension config path
      */
     private const XML_PATH_EXTENSION_ENABLED = 'loginascustomer/general/enabled';
-    private const STORE_VIEW_TO_LOGIN_IN = 'loginascustomer/general/store_view_login';
+    private const ENABLE_STORE_VIEW_MANUAL_CHOICE = 'loginascustomer/general/enable_store_view_manual_choice';
 
     /**
      * @var ScopeConfigInterface
@@ -34,7 +34,6 @@ class Config
     private $metadata;
 
     /**
-     * Config constructor.
      * @param ScopeConfigInterface $scopeConfig
      * @param ProductMetadataInterface $metadata
      */
@@ -47,37 +46,30 @@ public function __construct(
     }
 
     /**
-     * Retrieve store config value
-     * @param string $path
-     * @param null $storeId
-     * @return mixed
-     */
-    public function getConfig($path, $storeId = null)
-    {
-        return $this->scopeConfig->getValue(
-            $path,
-            ScopeInterface::SCOPE_STORE,
-            $storeId
-        );
-    }
-
-    /**
+     * Check if Login As Customer extension is enabled.
+     *
      * @return bool
      */
     public function isEnabled(): bool
     {
-        return (bool)$this->getConfig(
-            self::XML_PATH_EXTENSION_ENABLED
+        return (bool)$this->scopeConfig->getValue(
+            self::XML_PATH_EXTENSION_ENABLED,
+            ScopeInterface::SCOPE_STORE,
+            null
         );
     }
 
     /**
+     * Check if store view manual choice is enabled.
+     *
      * @return bool
      */
-    public function getStoreViewLogin(): bool
+    public function isManualChoiceEnabled(): bool
     {
-        return (bool)$this->getConfig(
-            self::STORE_VIEW_TO_LOGIN_IN
+        return (bool)$this->scopeConfig->getValue(
+            self::ENABLE_STORE_VIEW_MANUAL_CHOICE,
+            ScopeInterface::SCOPE_STORE,
+            null
         );
     }
 }

app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php

@@ -9,6 +9,8 @@
 
 /**
  * Page cache config plugin
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class ConfigPlugin
 {
@@ -44,10 +46,12 @@ public function __construct(
      * @param \Magento\PageCache\Model\Config $subject
      * @param bool $result
      * @return bool
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function afterIsEnabled(\Magento\PageCache\Model\Config $subject, $result): bool
     {
         if ($result) {
+
             $disable = $this->_scopeConfig->getValue(
                 'loginascustomer/general/disable_page_cache',
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE

app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php

@@ -11,7 +11,7 @@
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
 
 /**
- * Login as customer button
+ * Login As Customer button UI component.
  */
 class LoginAsCustomerButton extends GenericButton implements ButtonProviderInterface
 {
@@ -33,7 +33,7 @@ public function __construct(
     }
 
     /**
-     * @return array
+     * @inheritdoc
      */
     public function getButtonData(): array
     {
@@ -49,10 +49,13 @@ public function getButtonData(): array
                 'sort_order' => 70,
             ];
         }
+
         return $data;
     }
 
     /**
+     * Get Login As Customer login url.
+     *
      * @return string
      */
     public function getLoginUrl(): string

app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php

@@ -10,7 +10,7 @@
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
 
 /**
- * Class LoginAsCustomerButton
+ * Login As Customer button UI component.
  */
 class LoginAsCustomerButton implements ButtonProviderInterface
 {
@@ -32,4 +32,3 @@ public function getButtonData(): array
         ];
     }
 }
-

app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php

@@ -11,7 +11,7 @@
 use Magento\Ui\DataProvider\AbstractDataProvider;
 
 /**
- * Class StoreDataProvider
+ * Login As Customer store view form data provider.
  */
 class StoreDataProvider extends AbstractDataProvider
 {
@@ -34,5 +34,4 @@ public function __construct(
         $this->collection = $collectionFactory->create();
         parent::__construct($name, $primaryFieldName, $requestFieldName, $meta, $data);
     }
-
 }

app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml

@@ -23,7 +23,7 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment><![CDATA[If set to "Yes", when login as customer Page Cache will be disabled.]]></comment>
                 </field>
-                <field id="store_view_login" translate="label comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
+                <field id="enable_store_view_manual_choice" translate="label comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Store View To Login In</label>
                     <source_model>Magento\LoginAsCustomer\Model\Config\Source\StoreViewLogin</source_model>
                     <comment><![CDATA[