Skip to content

Commit 080420a

Browse files
Devagouda PatilDevagouda Patil
authored andcommitted
MAGETWO-90927: Warning on product save when all images are deleted (PHP 7.2)
- Updated existing Functional tests by removing commented lines per MAGETWO-91177 instructions
1 parent ab3d0f7 commit 080420a

File tree

6 files changed

+6
-18
lines changed

6 files changed

+6
-18
lines changed

app/code/Magento/Bundle/Test/Mftf/Test/AdminRemoveDefaultImageBundleProductTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@
7474
<!-- Remove image from product -->
7575
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
7676

77-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
78-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
79-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
77+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
8078

8179
<!-- Assert product image not in admin product form -->
8280
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminRemoveDefaultImageSimpleProductTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@
4646
<!-- Remove image from product -->
4747
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
4848

49-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
50-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
51-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
49+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
5250

5351
<!-- Assert product image not in admin product form -->
5452
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminRemoveDefaultImageVirtualProductTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@
4646
<!-- Remove image from product -->
4747
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
4848

49-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
50-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
51-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
49+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
5250

5351
<!-- Assert product image not in admin product form -->
5452
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminRemoveDefaultImageConfigurableTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@
109109
<!-- Remove image from product -->
110110
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
111111

112-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
113-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
114-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
112+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
115113

116114
<!-- Assert product image not in admin product form -->
117115
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

app/code/Magento/Downloadable/Test/Mftf/Test/AdminRemoveDefaultImageDownloadableProductTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@
5959
<!-- Remove image from product -->
6060
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
6161

62-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
63-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
64-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
62+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
6563

6664
<!-- Assert product image not in admin product form -->
6765
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

app/code/Magento/GroupedProduct/Test/Mftf/Test/AdminRemoveDefaultImageGroupedProductTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@
6969
<!-- Remove image from product -->
7070
<actionGroup ref="removeProductImage" stepKey="removeProductImage"/>
7171

72-
<!-- Skip success message check when saving product because of bug MAGETWO-91177 -->
73-
<!-- actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/-->
74-
<click selector="{{AdminProductFormActionSection.saveButton}}" stepKey="saveProductFormAfterRemove"/>
72+
<actionGroup ref="saveProductForm" stepKey="saveProductFormAfterRemove"/>
7573

7674
<!-- Assert product image not in admin product form -->
7775
<actionGroup ref="assertProductImageNotInAdminProductPage" stepKey="assertProductImageNotInAdminProductPage"/>

0 commit comments

Comments
 (0)