33378 GraphQL: move logger test to GenerateCustomerTokenTest.php; clean code

Author: khrystynastolbova

app/code/Magento/CustomerGraphQl/etc/graphql/events.xml

@@ -5,7 +5,8 @@
  * See COPYING.txt for license details.
  */
 -->
-<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
     <event name="customer_login">
         <observer name="customer_log_login" instance="Magento\Customer\Observer\LogLastLoginAtObserver" />
     </event>

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/GenerateCustomerTokenTest.php

@@ -7,24 +7,41 @@
 
 namespace Magento\GraphQl\Customer;
 
+use Magento\Customer\Model\Log;
+use Magento\Customer\Model\Logger;
+use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\TestCase\GraphQlAbstract;
 
 /**
  * API-functional tests cases for generateCustomerToken mutation
  */
 class GenerateCustomerTokenTest extends GraphQlAbstract
 {
+
+    /**
+     * @var Logger
+     */
+    private $logger;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->logger = Bootstrap::getObjectManager()->get(Logger::class);
+    }
+
     /**
      * Verify customer token with valid credentials
      *
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      */
-    public function testGenerateCustomerValidToken()
+    public function testGenerateCustomerValidToken(): void
     {
-        $email = 'customer@example.com';
-        $password = 'password';
-
-        $mutation = $this->getQuery($email, $password);
+        $mutation = $this->getQuery();
 
         $response = $this->graphQlMutation($mutation);
         $this->assertArrayHasKey('generateCustomerToken', $response);
@@ -41,7 +58,7 @@ public function testGenerateCustomerValidToken()
      * @param string $password
      * @param string $message
      */
-    public function testGenerateCustomerTokenInvalidData(string $email, string $password, string $message)
+    public function testGenerateCustomerTokenInvalidData(string $email, string $password, string $message): void
     {
         $this->expectException(\Exception::class);
 
@@ -55,12 +72,9 @@ public function testGenerateCustomerTokenInvalidData(string $email, string $pass
      *
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      */
-    public function testRegenerateCustomerToken()
+    public function testRegenerateCustomerToken(): void
     {
-        $email = 'customer@example.com';
-        $password = 'password';
-
-        $mutation = $this->getQuery($email, $password);
+        $mutation = $this->getQuery();
 
         $response1 = $this->graphQlMutation($mutation);
         $token1 = $response1['generateCustomerToken']['token'];
@@ -110,7 +124,7 @@ public function dataProviderInvalidCustomerInfo(): array
      * @param string $password
      * @return string
      */
-    private function getQuery(string $email, string $password) : string
+    private function getQuery(string $email = 'customer@example.com', string $password = 'password'): string
     {
         return <<<MUTATION
 mutation {
@@ -127,22 +141,12 @@ private function getQuery(string $email, string $password) : string
     /**
      * Verify customer with empty email
      */
-    public function testGenerateCustomerTokenWithEmptyEmail()
+    public function testGenerateCustomerTokenWithEmptyEmail(): void
     {
         $email = '';
         $password = 'bad-password';
 
-        $mutation
-            = <<<MUTATION
-mutation {
-	generateCustomerToken(
-        email: "{$email}"
-        password: "{$password}"
-    ) {
-        token
-    }
-}
-MUTATION;
+        $mutation = $this->getQuery($email, $password);
 
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage('GraphQL response contains errors: Specify the "email" value.');
@@ -152,25 +156,51 @@ public function testGenerateCustomerTokenWithEmptyEmail()
     /**
      * Verify customer with empty password
      */
-    public function testGenerateCustomerTokenWithEmptyPassword()
+    public function testGenerateCustomerTokenWithEmptyPassword(): void
     {
         $email = 'customer@example.com';
         $password = '';
 
-        $mutation
-            = <<<MUTATION
-mutation {
-	generateCustomerToken(
-        email: "{$email}"
-        password: "{$password}"
-    ) {
-        token
-    }
-}
-MUTATION;
+        $mutation = $this->getQuery($email, $password);
 
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage('GraphQL response contains errors: Specify the "password" value.');
         $this->graphQlMutation($mutation);
     }
+
+    /**
+     * Verify customer log after generate customer token
+     *
+     * @magentoApiDataFixture Magento/Customer/_files/customer.php
+     */
+    public function testCustomerLogAfterGenerateCustomerToken(): void
+    {
+        $response = $this->graphQlMutation($this->getQuery());
+        $this->assertArrayHasKey('generateCustomerToken', $response);
+        $this->assertIsArray($response['generateCustomerToken']);
+
+        /** @var Log $log */
+        $log = $this->logger->get(1);
+        $this->assertNotEmpty($log->getLastLoginAt());
+    }
+
+    /**
+     * Ensure that customer log record is deleted.
+     *
+     * @return void
+     */
+    protected function tearDown(): void
+    {
+        if ($this->logger->get(1)->getLastLoginAt()) {
+            /** @var AdapterInterface $connection */
+            /** @var ResourceConnection $resource */
+            $resource = Bootstrap::getObjectManager()->get(ResourceConnection::class);
+            $connection = $resource->getConnection(ResourceConnection::DEFAULT_CONNECTION);
+            $connection->delete(
+                $resource->getTableName('customer_log'),
+                ['customer_id' => 1]
+            );
+        }
+        parent::tearDown();
+    }
 }