Skip to content

Commit 073b844

Browse files
committed
MAGETWO-97025: Check Url Rewrites Correctly Generated for Multiple Storeviews During Product Import
1 parent f07f4a3 commit 073b844

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,14 @@
5252
<conditionalClick selector="{{AdminProductGridFilterSection.clearFilters}}" dependentSelector="{{AdminProductGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFiltersInitial2"/>
5353
</actionGroup>
5454

55-
<actionGroup name="deleteProductByName" extends="deleteProductUsingProductGrid">
55+
<actionGroup name="DeleteProductByName" extends="deleteProductUsingProductGrid">
5656
<arguments>
57-
<argument name="product" type="string" defaultValue=""/>
58-
<argument name="name" type="string"/>
57+
<argument name="product" type="string"/>
5958
</arguments>
6059
<remove keyForRemoval="fillProductSkuFilter"/>
61-
<fillField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{name}}" stepKey="fillProductSkuFilter" after="openProductFilters"/>
60+
<fillField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{product}}" stepKey="fillProductSkuFilter" after="openProductFilters"/>
6261
<remove keyForRemoval="seeProductSkuInGrid"/>
63-
<see selector="{{AdminProductGridSection.productGridCell('1', 'Name')}}" userInput="{{name}}" stepKey="seeProductNameInGrid" after="clickApplyFilters"/>
62+
<see selector="{{AdminProductGridSection.productGridCell('1', 'Name')}}" userInput="{{product}}" stepKey="seeProductNameInGrid" after="clickApplyFilters"/>
6463
</actionGroup>
6564

6665
<!--Disabled a product by filtering grid and using change status action-->

app/code/Magento/Store/Test/Mftf/Data/StoreData.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<data key="store_type">store</data>
4040
<requiredEntity type="storeGroup">customStoreGroup</requiredEntity>
4141
</entity>
42-
<entity name="customStoreENNotUnique" type="store">
42+
<entity name="CustomStoreENNotUnique" type="store">
4343
<data key="name">EN</data>
4444
<data key="code">en</data>
4545
<data key="is_active">1</data>
@@ -48,7 +48,7 @@
4848
<data key="store_type">store</data>
4949
<requiredEntity type="storeGroup">customStoreGroup</requiredEntity>
5050
</entity>
51-
<entity name="customStoreNLNotUnique" type="store">
51+
<entity name="CustomStoreNLNotUnique" type="store">
5252
<data key="name">NL</data>
5353
<data key="code">nl</data>
5454
<data key="is_active">1</data>

app/code/Magento/Store/Test/Mftf/Section/AdminNewStoreViewActionsSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@
1111
<element name="delete" type="button" selector="#delete" timeout="30"/>
1212
<element name="resetButton" type="button" selector="#reset" timeout="30"/>
1313
<element name="saveButton" type="button" selector="#save" timeout="60"/>
14-
<element name="loadingMask" type="text" selector=".loading-mask"/>
1514
</section>
1615
</sections>

app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminCheckUrlRewritesCorrectlyGeneratedForMultipleStoreviewsDuringProductImportTest.xml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,33 +21,31 @@
2121
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2222
<!-- Create Store View EN -->
2323
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreViewEn">
24-
<argument name="customStore" value="customStoreENNotUnique"/>
24+
<argument name="customStore" value="CustomStoreENNotUnique"/>
2525
</actionGroup>
2626
<!-- Create Store View NL -->
2727
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreViewNl">
28-
<argument name="customStore" value="customStoreNLNotUnique"/>
28+
<argument name="customStore" value="CustomStoreNLNotUnique"/>
2929
</actionGroup>
3030
<createData entity="ApiCategory" stepKey="createCategory">
3131
<field key="name">category-admin</field>
3232
</createData>
3333
</before>
3434
<after>
3535
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
36-
<actionGroup ref="deleteProductByName" stepKey="deleteImportedProduct">
36+
<actionGroup ref="DeleteProductByName" stepKey="deleteImportedProduct">
3737
<argument name="product" value="productformagetwo76287"/>
38-
<argument name="name" value="productformagetwo76287"/>
3938
</actionGroup>
40-
<actionGroup ref="clearFiltersAdminDataGrid" stepKey="clearFiltersIfSet"/>
4139
<actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreViewEn">
42-
<argument name="customStore" value="customStoreENNotUnique"/>
40+
<argument name="customStore" value="CustomStoreENNotUnique"/>
4341
</actionGroup>
4442
<actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreViewNl">
45-
<argument name="customStore" value="customStoreNLNotUnique"/>
43+
<argument name="customStore" value="CustomStoreNLNotUnique"/>
4644
</actionGroup>
4745
<actionGroup ref="logout" stepKey="logout"/>
4846
</after>
4947
<actionGroup ref="switchCategoryStoreView" stepKey="switchToStoreViewEn">
50-
<argument name="store" value="customStoreENNotUnique.name"/>
48+
<argument name="store" value="CustomStoreENNotUnique.name"/>
5149
<argument name="catName" value="$$createCategory.name$$"/>
5250
</actionGroup>
5351
<uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValueENStoreView"/>
@@ -57,7 +55,7 @@
5755
<argument name="value" value="category-english"/>
5856
</actionGroup>
5957
<actionGroup ref="switchCategoryStoreView" stepKey="switchToStoreViewNl">
60-
<argument name="store" value="customStoreNLNotUnique.name"/>
58+
<argument name="store" value="CustomStoreNLNotUnique.name"/>
6159
<argument name="catName" value="$$createCategory.name$$"/>
6260
</actionGroup>
6361
<uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValue1"/>

0 commit comments

Comments
 (0)