ENGCOM-5990: Static Content Deploy - Sort JS Translations to have them in the same order on every build #24828

Author: sidolov

app/code/Magento/Translation/Model/Js/DataProvider.php

@@ -120,6 +120,8 @@ public function getData($themePath)
             }
         }
 
+        ksort($dictionary);
+
         return $dictionary;
     }
 

app/code/Magento/Translation/Test/Unit/Model/Js/DataProviderTest.php

@@ -90,7 +90,7 @@ public function testGetData()
         $themePath = 'blank';
         $areaCode = 'adminhtml';
 
-        $filePaths = [['path1'], ['path2'], ['path3'], ['path4']];
+        $filePaths = [['path1'], ['path2'], ['path4'], ['path3']];
 
         $jsFilesMap = [
             ['base', $themePath, '*', '*', [$filePaths[0]]],
@@ -111,8 +111,8 @@ public function testGetData()
         $contentsMap = [
             'content1$.mage.__("hello1")content1',
             'content2$.mage.__("hello2")content2',
+            'content2$.mage.__("hello4")content4', // this value should be last after running data provider
             'content2$.mage.__("hello3")content3',
-            'content2$.mage.__("hello4")content4'
         ];
 
         $translateMap = [
@@ -147,7 +147,13 @@ public function testGetData()
             ->method('render')
             ->willReturnMap($translateMap);
 
-        $this->assertEquals($expectedResult, $this->model->getData($themePath));
+        $actualResult = $this->model->getData($themePath);
+        $this->assertEquals($expectedResult, $actualResult);
+        $this->assertEquals(
+            json_encode($expectedResult),
+            json_encode($actualResult),
+            "Translations should be sorted by key"
+        );
     }
 
     /**