Skip to content

Commit 06e9920

Browse files
committed
MAGETWO-54682: Fast load of product options
- fix tests
1 parent 3ca52f0 commit 06e9920

File tree

8 files changed

+8
-12
lines changed

8 files changed

+8
-12
lines changed

app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,5 +372,4 @@ protected function copyImage($file)
372372
);
373373
}
374374
}
375-
376375
}

app/code/Magento/CatalogRule/Test/Unit/Pricing/Price/CatalogRulePriceTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
/**
1212
* Class CatalogRulePriceTest
13+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1314
*/
1415
class CatalogRulePriceTest extends \PHPUnit_Framework_TestCase
1516
{

app/code/Magento/CatalogRuleConfigurable/Plugin/ConfigurableProduct/Model/ResourceModel/AddCatalogRulePrice.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,4 @@ public function beforeLoad(Collection $productCollection, $printQuery = false, $
9191

9292
return [$printQuery, $logQuery];
9393
}
94-
}
94+
}

app/code/Magento/CatalogRuleConfigurable/composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
"require": {
55
"php": "~5.5.0|~5.6.0|~7.0.0",
66
"magento/module-configurable-product": "100.0.*",
7+
"magento/module-catalog-rule": "100.0.*",
8+
"magento/module-store": "100.0.*",
9+
"magento/module-customer": "100.0.*",
710
"magento/framework": "100.0.*",
811
"magento/magento-composer-installer": "*"
912
},
10-
"suggest": {
11-
"magento/module-catalog-rule": "100.0.*"
12-
},
1313
"type": "magento2-module",
1414
"version": "100.0.5",
1515
"license": [

app/code/Magento/ConfigurableProduct/Pricing/Price/ConfigurablePriceResolver.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public function resolvePrice(\Magento\Framework\Pricing\SaleableInterface $produ
7272

7373
/**
7474
* @return \Magento\ConfigurableProduct\Pricing\Price\ConfigurableOptionsProviderInterface
75+
* @deprecated
7576
*/
7677
private function getConfigurableOptionsProvider()
7778
{

app/code/Magento/ConfigurableProduct/Pricing/Price/ConfigurableRegularPrice.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ protected function getUsedProducts()
152152

153153
/**
154154
* @return \Magento\ConfigurableProduct\Pricing\Price\ConfigurableOptionsProviderInterface
155+
* @deprecated
155156
*/
156157
private function getConfigurableOptionsProvider()
157158
{

app/code/Magento/ProductVideo/Model/Plugin/ExternalVideoResourceBackend.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,5 +89,4 @@ public function afterCreateBatchBaseSelect(Media $originalResourceModel, Select
8989

9090
return $select;
9191
}
92-
9392
}

app/code/Magento/ProductVideo/Test/Unit/Model/Plugin/ExternalVideoEntryProcessorTest.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,13 +274,8 @@ public function testAfterLoadNoVideo()
274274
'values' => []
275275
];
276276

277-
$resourceEntryResult = [];
278-
279277
$this->productMock->expects($this->once())->method('getData')->with('media_gallery')->willReturn($mediaData);
280-
281-
$this->resourceEntryMediaGalleryMock->expects($this->once())->method('loadDataFromTableByValueId')->willReturn(
282-
$resourceEntryResult
283-
);
278+
$this->resourceEntryMediaGalleryMock->expects($this->never())->method('loadDataFromTableByValueId');
284279
$this->mediaBackendModel->expects($this->any())->method('getAttribute')->willReturn($this->attributeMock);
285280

286281
$this->modelObject->afterAfterLoad($this->mediaBackendModel, $this->productMock);

0 commit comments

Comments
 (0)