MAGETWO-87934: Cast handling fee to float #13680

magento-engcom-team · magento-engcom-team · commit 069dad64b6d3 · 2018-02-15T15:56:13.000-06:00
- Merge Pull Request #13680 from schmengler/magento2:handling-fee - Merged commits: 1. 4298849
diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php
@@ -454,7 +454,7 @@ protected function _updateFreeMethodQuote($request)
      */
     public function getFinalPriceWithHandlingFee($cost)
     {
-        $handlingFee = $this->getConfigData('handling_fee');
+        $handlingFee = (float)$this->getConfigData('handling_fee');
         $handlingType = $this->getConfigData('handling_type');
         if (!$handlingType) {
             $handlingType = self::HANDLING_TYPE_FIXED;

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ protected function _updateFreeMethodQuote($request)`
`454`	`454`	`*/`
`455`	`455`	`public function getFinalPriceWithHandlingFee($cost)`
`456`	`456`	`{`
`457`		`- $handlingFee = $this->getConfigData('handling_fee');`
	`457`	`+ $handlingFee = (float)$this->getConfigData('handling_fee');`
`458`	`458`	`$handlingType = $this->getConfigData('handling_type');`
`459`	`459`	`if (!$handlingType) {`
`460`	`460`	`$handlingType = self::HANDLING_TYPE_FIXED;`