Skip to content

Commit 065a9b7

Browse files
committed
MAGETWO-87526: URL rewrite for store is not created for child if parent category has non-default URL key on store
1 parent 71e8f77 commit 065a9b7

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Category/UpdateUrlPath.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55
*/
66
namespace Magento\CatalogUrlRewrite\Model\Category\Plugin\Category;
77

8-
use \Magento\Catalog\Model\Category;
9-
use \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator;
10-
use \Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator;
11-
use \Magento\CatalogUrlRewrite\Service\V1\StoreViewService;
12-
use \Magento\UrlRewrite\Model\UrlPersistInterface;
13-
use \Magento\Store\Model\Store;
14-
use \Magento\Catalog\Model\ResourceModel\Category as CategoryResource;
8+
use Magento\Framework\Model\AbstractModel;
9+
use Magento\Catalog\Model\Category;
10+
use Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator;
11+
use Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator;
12+
use Magento\CatalogUrlRewrite\Service\V1\StoreViewService;
13+
use Magento\UrlRewrite\Model\UrlPersistInterface;
14+
use Magento\Store\Model\Store;
15+
use Magento\Catalog\Model\ResourceModel\Category as CategoryResource;
1516

1617
/**
1718
* Generate and save url-rewrites for category if its parent have specified url-key for different store views
@@ -61,14 +62,14 @@ public function __construct(
6162
*
6263
* @param CategoryResource $subject
6364
* @param CategoryResource $result
64-
* @param Category $category
65+
* @param AbstractModel $category
6566
* @return CategoryResource
6667
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
6768
*/
6869
public function afterSave(
6970
CategoryResource $subject,
7071
CategoryResource $result,
71-
Category $category
72+
AbstractModel $category
7273
) {
7374
$parentCategoryId = $category->getParentId();
7475
if ($category->isObjectNew()

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Category/UpdateUrlPathTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ public function testAroundSaveWithoutRootCategory()
114114
$this->category->expects($this->atLeastOnce())->method('isInRootCategoryList')->willReturn(false);
115115
$this->category->expects($this->never())->method('getStoreIds');
116116

117-
$this->assertEquals(
118-
$this->categoryResource,
119-
$this->updateUrlPathPlugin->afterSave($this->categoryResource, $this->categoryResource, $this->category)
120-
);
117+
$this->assertEquals(
118+
$this->categoryResource,
119+
$this->updateUrlPathPlugin->afterSave($this->categoryResource, $this->categoryResource, $this->category)
120+
);
121121
}
122122

123123
public function testAroundSaveWithRootCategory()

0 commit comments

Comments
 (0)