🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #21421: Improve swatch table overflow handling (by @Cyanoxide)
 - #21426: fixes-for-product-page-product-in-website-multi-store-view-not-displa� (by @priti2jcommerce)
 - #21429: Correct spelling (by @ravi-chandra3197)
 - #21431: Fix grammar (by @DanielRuf)
 - #21295: Fix empty cart validation (by @wojtekn)
 - #21395: As low as displays incorrect pricing on category page, tax appears to be added twice #21383 (by @Jitheesh)
 - #21405: Removed unused else block and corrected return types (by @yogeshsuhagiya)
 - #21401: Show error message when customer click on Add to cart button without selecting atleast one product from recently orderred list (by @mageprince)
 - #21105: Fixed pagination issue in admin review grid (by @dominicfernando)
 - #21330: Change comment to "database" (by @DanielRuf)
 - #21302: Misconfigured aria-labelledby for product tabs (by @mageho)
 - #20858: Update details.phtml (by @mageho)
 - #20578: Added original exception as the cause to the new exception on product delete error (by @woutersamaey)
 - #20339: issue fixed #20337 Option Title breaking in two line because applying� (by @cedarvinda)
 - #20044:  Sitemap filename can't exceed 32 characters #13937  (by @irajneeshgupta)


Fixed GitHub Issues:
 - #21294: Cart can't be emptied if any product is out of stock (reported by @wojtekn) has been fixed in #21295 by @wojtekn in 2.3-develop branch
   Related commits:
     1. 4cdcb74
     2. f6656f9
     3. 96793fe
     4. f82299b
     5. a1578b5

 - #21383: As low as displays incorrect pricing on category page, tax appears to be added twice (reported by @devchris79) has been fixed in #21395 by @Jitheesh in 2.3-develop branch
   Related commits:
     1. c9fff89
     2. 70f2599

 - #21398: Doesn't show any error message when customer click on Add to cart button without selecting atleast one product from recently orderred list (reported by @mageprince) has been fixed in #21401 by @mageprince in 2.3-develop branch
   Related commits:
     1. 0df8d31
     2. adccc57
     3. d4a5b46
     4. fa95b94

 - #20337: Option Title breaking in two line because applying  wrong css for manage width (reported by @swetacedcoss) has been fixed in #20339 by @cedarvinda in 2.3-develop branch
   Related commits:
     1. 74b2098
     2. d7ba787

 - #13937: Sitemap filename can't exceed 32 characters (reported by @erikhansen) has been fixed in #20044 by @irajneeshgupta in 2.3-develop branch
   Related commits:
     1. 55cf2dc
     2. 035e8d7
     3. 417ffa2
     4. e9f4981
     5. 94c176f

Author: magento-engcom-team

app/code/Magento/Backend/etc/adminhtml/system.xml

@@ -112,7 +112,7 @@
             <group id="debug" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
                 <label>Debug</label>
                 <field id="template_hints_storefront" translate="label" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
-                    <label>Enabled Template Path Hints for Storefront</label>
+                    <label>Enable Template Path Hints for Storefront</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
                 <field id="template_hints_storefront_show_with_parameter" translate="label" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
@@ -132,7 +132,7 @@
                     <comment>Add the following parameter to the URL to show template hints ?templatehints=[parameter_value]</comment>
                 </field>
                 <field id="template_hints_admin" translate="label" type="select" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="0">
-                    <label>Enabled Template Path Hints for Admin</label>
+                    <label>Enable Template Path Hints for Admin</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
                 <field id="template_hints_blocks" translate="label" type="select" sortOrder="21" showInDefault="1" showInWebsite="1" showInStore="1">

app/code/Magento/Catalog/Model/ProductRepository.php

@@ -644,10 +644,11 @@ public function delete(ProductInterface $product)
             unset($this->instancesById[$product->getId()]);
             $this->resourceModel->delete($product);
         } catch (ValidatorException $e) {
-            throw new CouldNotSaveException(__($e->getMessage()));
+            throw new CouldNotSaveException(__($e->getMessage()), $e);
         } catch (\Exception $e) {
             throw new \Magento\Framework\Exception\StateException(
-                __('The "%1" product couldn\'t be removed.', $sku)
+                __('The "%1" product couldn\'t be removed.', $sku),
+                $e
             );
         }
         $this->removeProductFromLocalCache($sku);

app/code/Magento/Catalog/Pricing/Price/MinimalTierPriceCalculator.php

@@ -29,8 +29,10 @@ public function __construct(CalculatorInterface $calculator)
     }
 
     /**
-     * Get raw value of "as low as" as a minimal among tier prices
-     * {@inheritdoc}
+     * Get raw value of "as low as" as a minimal among tier prices{@inheritdoc}
+     *
+     * @param SaleableInterface $saleableItem
+     * @return float|null
      */
     public function getValue(SaleableInterface $saleableItem)
     {
@@ -49,15 +51,17 @@ public function getValue(SaleableInterface $saleableItem)
     }
 
     /**
-     * Return calculated amount object that keeps "as low as" value
-     * {@inheritdoc}
+     * Return calculated amount object that keeps "as low as" value{@inheritdoc}
+     *
+     * @param SaleableInterface $saleableItem
+     * @return AmountInterface|null
      */
     public function getAmount(SaleableInterface $saleableItem)
     {
         $value = $this->getValue($saleableItem);
 
         return $value === null
             ? null
-            : $this->calculator->getAmount($value, $saleableItem);
+            : $this->calculator->getAmount($value, $saleableItem, 'tax');
     }
 }

app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml

@@ -22,17 +22,17 @@
                     $label = $block->getChildData($alias, 'title');
                 ?>
                 <div class="data item title"
-                     aria-labelledby="tab-label-<?= /* @escapeNotVerified */ $alias ?>-title"
                      data-role="collapsible" id="tab-label-<?= /* @escapeNotVerified */ $alias ?>">
                     <a class="data switch"
                        tabindex="-1"
-                       data-toggle="switch"
+                       data-toggle="trigger"
                        href="#<?= /* @escapeNotVerified */ $alias ?>"
                        id="tab-label-<?= /* @escapeNotVerified */ $alias ?>-title">
                         <?= /* @escapeNotVerified */ $label ?>
                     </a>
                 </div>
-                <div class="data item content" id="<?= /* @escapeNotVerified */ $alias ?>" data-role="content">
+                <div class="data item content" 
+                     aria-labelledby="tab-label-<?= /* @escapeNotVerified */ $alias ?>-title" id="<?= /* @escapeNotVerified */ $alias ?>" data-role="content">
                     <?= /* @escapeNotVerified */ $html ?>
                 </div>
             <?php endforeach;?>

app/code/Magento/Checkout/Controller/Cart/Addgroup.php

@@ -4,17 +4,21 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Checkout\Controller\Cart;
 
 use Magento\Checkout\Model\Cart as CustomerCart;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\Escaper;
 use Magento\Framework\App\ObjectManager;
 use Magento\Sales\Model\Order\Item;
 
 /**
+ * Add grouped items controller.
+ *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
-class Addgroup extends \Magento\Checkout\Controller\Cart
+class Addgroup extends \Magento\Checkout\Controller\Cart implements HttpPostActionInterface
 {
     /**
      * @var Escaper
@@ -44,6 +48,8 @@ public function __construct(
     }
 
     /**
+     * Add items in group.
+     *
      * @return \Magento\Framework\Controller\Result\Redirect
      */
     public function execute()
@@ -74,6 +80,8 @@ public function execute()
                 }
             }
             $this->cart->save();
+        } else {
+            $this->messageManager->addErrorMessage(__('Please select at least one product to add to cart'));
         }
         return $this->_goBack();
     }

app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml

@@ -14,7 +14,8 @@
           method="post"
           id="form-validate"
           data-mage-init='{"Magento_Checkout/js/action/update-shopping-cart":
-              {"validationURL" : "/checkout/cart/updateItemQty"}
+              {"validationURL" : "/checkout/cart/updateItemQty",
+              "updateCartActionContainer": "#update_cart_action_container"}
           }'
           class="form form-cart">
     <?= $block->getBlockHtml('formkey') ?>

app/code/Magento/Checkout/view/frontend/web/js/action/update-shopping-cart.js

@@ -14,7 +14,8 @@ define([
     $.widget('mage.updateShoppingCart', {
         options: {
             validationURL: '',
-            eventName: 'updateCartItemQty'
+            eventName: 'updateCartItemQty',
+            updateCartActionContainer: ''
         },
 
         /** @inheritdoc */
@@ -31,7 +32,9 @@ define([
          * @return {Boolean}
          */
         onSubmit: function (event) {
-            if (!this.options.validationURL) {
+            var action = this.element.find(this.options.updateCartActionContainer).val();
+
+            if (!this.options.validationURL || action === 'empty_cart') {
                 return true;
             }
 

app/code/Magento/Fedex/Model/Carrier.php

@@ -363,7 +363,6 @@ public function setRequest(RateRequest $request)
 
         if ($request->getDestPostcode()) {
             $r->setDestPostal($request->getDestPostcode());
-        } else {
         }
 
         if ($request->getDestCity()) {

app/code/Magento/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php

@@ -171,7 +171,7 @@ public function getMessage()
     /**
      * Retrieve save url
      *
-     * @return array
+     * @return string
      * @codeCoverageIgnore
      */
     public function getSaveUrl()

app/code/Magento/GiftMessage/Block/Cart/GiftOptions.php

@@ -3,13 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\GiftMessage\Block\Cart;
 
 use Magento\Backend\Block\Template\Context;
 use Magento\Framework\Json\Encoder;
 use Magento\GiftMessage\Model\CompositeConfigProvider;
 
 /**
+ * Gift options cart block.
+ *
  * @api
  * @since 100.0.2
  */
@@ -63,6 +66,8 @@ public function __construct(
     }
 
     /**
+     * Retrieve encoded js layout.
+     *
      * @return string
      */
     public function getJsLayout()
@@ -76,7 +81,7 @@ public function getJsLayout()
     /**
      * Retrieve gift message configuration
      *
-     * @return array
+     * @return string
      */
     public function getGiftOptionsConfigJson()
     {