Skip to content

Commit 06237d6

Browse files
committed
Added check for truthy value of $requestData variable in case of null
1 parent 43cb064 commit 06237d6

File tree

1 file changed

+5
-8
lines changed
  • app/code/Magento/Braintree/Controller/Paypal

1 file changed

+5
-8
lines changed

app/code/Magento/Braintree/Controller/Paypal/Review.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function execute()
6060
try {
6161
$this->validateQuote($quote);
6262

63-
if ($this->validateRequestData($requestData)) {
63+
if ($requestData && $this->validateRequestData($requestData)) {
6464
$this->quoteUpdater->execute(
6565
$requestData['nonce'],
6666
$requestData['details'],
@@ -91,14 +91,11 @@ public function execute()
9191
}
9292

9393
/**
94-
* @param $requestData
95-
* @return bool
94+
* @param array $requestData
95+
* @return boolean
9696
*/
97-
private function validateRequestData($requestData)
97+
private function validateRequestData(array $requestData)
9898
{
99-
if (is_array($requestData)) {
100-
return !empty($requestData['nonce']) && !empty($requestData['details']);
101-
}
102-
return false;
99+
return !empty($requestData['nonce']) && !empty($requestData['details']);
103100
}
104101
}

0 commit comments

Comments
 (0)