Skip to content

Commit 05ebdb9

Browse files
author
Olga Nakonechna
committed
MAGETWO-44706: Scroll up when open MAP pop-up on Category page
1 parent 0be91a5 commit 05ebdb9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

app/code/Magento/Catalog/view/base/templates/product/price/tier_prices.phtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ $product = $block->getSaleableItem();
5454
}
5555
?>
5656
<?php /* @escapeNotVerified */ echo __('Buy %1 for: ', $price['price_qty']); ?>
57-
<a href="#" id="<?php /* @escapeNotVerified */ echo($popupId);?>"
57+
<a href="javascript:void(0);"
58+
id="<?php /* @escapeNotVerified */ echo($popupId);?>"
5859
data-tier-price="<?php echo $block->escapeHtml($block->jsonEncode($tierPriceData)); ?>">
5960
<?php /* @escapeNotVerified */ echo __('Click for price'); ?></a>
6061
<?php else:

app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ if ($product->isSaleable()) {
7373
}
7474
?>
7575
<span id="<?php /* @escapeNotVerified */ echo $block->getPriceId() ? $block->getPriceId() : $priceElementId ?>" style="display:none"></span>
76-
<a href="#"
76+
<a href="javascript:void(0);"
7777
id="<?php /* @escapeNotVerified */ echo($popupId);?>"
7878
class="action map-show-info"
7979
data-mage-init="<?=$block->escapeHtml($this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($data))?>"><?php /* @escapeNotVerified */ echo __('Click for price'); ?>
@@ -86,7 +86,7 @@ if ($product->isSaleable()) {
8686

8787
<?php if ($block->getZone() == \Magento\Framework\Pricing\Render::ZONE_ITEM_VIEW): ?>
8888
<?php $helpLinkId = 'msrp-help-' . $productId . $block->getRandomString(20); ?>
89-
<a href="#"
89+
<a href="javascript:void(0);"
9090
id="<?php /* @escapeNotVerified */ echo $helpLinkId;?>"
9191
class="action map-show-info"
9292
data-mage-init='{"addToCart":{"helpLinkId": "#<?php /* @escapeNotVerified */ echo $helpLinkId;?>",

app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_item.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<?php $priceElementId = 'product-price-' . $_id . $block->getIdSuffix(); ?>
3636
<span id="<?php /* @escapeNotVerified */ echo $priceElementId ?>" style="display: none"></span>
3737
<?php $popupId = 'msrp-popup-' . $_id . $block->getRandomString(20); ?>
38-
<a href="#"
38+
<a href="javascript:void(0);"
3939
id="<?php /* @escapeNotVerified */ echo($popupId);?>"
4040
data-mage-init='{"addToCart":{"popupId": "#<?php /* @escapeNotVerified */ echo($popupId);?>",
4141
"productName": "<?php /* @escapeNotVerified */ echo $_product->getName() ?>",
@@ -51,5 +51,5 @@
5151
</span>
5252
<?php endif; ?>
5353
<?php $helpLinkId = 'msrp-help-' . $_id . $block->getRandomString(20); ?>
54-
<a href="#" id="<?php /* @escapeNotVerified */ echo($helpLinkId);?>" data-mage-init='{"addToCart":{"helpLinkId": "#<?php /* @escapeNotVerified */ echo($helpLinkId);?>", "productName": "<?php /* @escapeNotVerified */ echo $_product->getName() ?>"}}' class="link tip"><?php /* @escapeNotVerified */ echo __("What's this?"); ?></a>
54+
<a href="javascript:void(0);" id="<?php /* @escapeNotVerified */ echo($helpLinkId);?>" data-mage-init='{"addToCart":{"helpLinkId": "#<?php /* @escapeNotVerified */ echo($helpLinkId);?>", "productName": "<?php /* @escapeNotVerified */ echo $_product->getName() ?>"}}' class="link tip"><?php /* @escapeNotVerified */ echo __("What's this?"); ?></a>
5555
</div>

0 commit comments

Comments
 (0)