Skip to content

Commit 057e8d1

Browse files
committed
MAGETWO-50552: Four decimal characters saved in new product attribute with type "Price"
- Updated properties in unit tests to private;
1 parent dadfe1c commit 057e8d1

File tree

2 files changed

+22
-22
lines changed
  • app/code/Magento
    • Catalog/Test/Unit/Ui/DataProvider/Product/Form/Modifier
    • Msrp/Test/Unit/Ui/DataProvider/Product/Form/Modifier

2 files changed

+22
-22
lines changed

app/code/Magento/Catalog/Test/Unit/Ui/DataProvider/Product/Form/Modifier/EavTest.php

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -41,102 +41,102 @@ class EavTest extends AbstractModifierTest
4141
/**
4242
* @var Config|\PHPUnit_Framework_MockObject_MockObject
4343
*/
44-
protected $eavConfigMock;
44+
private $eavConfigMock;
4545

4646
/**
4747
* @var EavValidationRules|\PHPUnit_Framework_MockObject_MockObject
4848
*/
49-
protected $eavValidationRulesMock;
49+
private $eavValidationRulesMock;
5050

5151
/**
5252
* @var RequestInterface|\PHPUnit_Framework_MockObject_MockObject
5353
*/
54-
protected $requestMock;
54+
private $requestMock;
5555

5656
/**
5757
* @var GroupCollectionFactory|\PHPUnit_Framework_MockObject_MockObject
5858
*/
59-
protected $groupCollectionFactoryMock;
59+
private $groupCollectionFactoryMock;
6060

6161
/**
6262
* @var GroupCollection|\PHPUnit_Framework_MockObject_MockObject
6363
*/
64-
protected $groupCollectionMock;
64+
private $groupCollectionMock;
6565

6666
/**
6767
* @var Group|\PHPUnit_Framework_MockObject_MockObject
6868
*/
69-
protected $groupMock;
69+
private $groupMock;
7070

7171
/**
7272
* @var EavAttribute|\PHPUnit_Framework_MockObject_MockObject
7373
*/
74-
protected $attributeMock;
74+
private $attributeMock;
7575

7676
/**
7777
* @var EntityType|\PHPUnit_Framework_MockObject_MockObject
7878
*/
79-
protected $entityTypeMock;
79+
private $entityTypeMock;
8080

8181
/**
8282
* @var AttributeCollection|\PHPUnit_Framework_MockObject_MockObject
8383
*/
84-
protected $attributeCollectionMock;
84+
private $attributeCollectionMock;
8585

8686
/**
8787
* @var StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
8888
*/
89-
protected $storeManagerMock;
89+
private $storeManagerMock;
9090

9191
/**
9292
* @var FormElementMapper|\PHPUnit_Framework_MockObject_MockObject
9393
*/
94-
protected $formElementMapperMock;
94+
private $formElementMapperMock;
9595

9696
/**
9797
* @var MetaPropertiesMapper|\PHPUnit_Framework_MockObject_MockObject
9898
*/
99-
protected $metaPropertiesMapperMock;
99+
private $metaPropertiesMapperMock;
100100

101101
/**
102102
* @var SearchCriteriaBuilder|\PHPUnit_Framework_MockObject_MockObject
103103
*/
104-
protected $searchCriteriaBuilderMock;
104+
private $searchCriteriaBuilderMock;
105105

106106
/**
107107
* @var ProductAttributeGroupRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
108108
*/
109-
protected $attributeGroupRepositoryMock;
109+
private $attributeGroupRepositoryMock;
110110

111111
/**
112112
* @var SearchCriteria|\PHPUnit_Framework_MockObject_MockObject
113113
*/
114-
protected $searchCriteriaMock;
114+
private $searchCriteriaMock;
115115

116116
/**
117117
* @var SortOrderBuilder|\PHPUnit_Framework_MockObject_MockObject
118118
*/
119-
protected $sortOrderBuilderMock;
119+
private $sortOrderBuilderMock;
120120

121121
/**
122122
* @var ProductAttributeRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
123123
*/
124-
protected $attributeRepositoryMock;
124+
private $attributeRepositoryMock;
125125

126126
/**
127127
* @var AttributeGroupInterface|\PHPUnit_Framework_MockObject_MockObject
128128
*/
129-
protected $attributeGroupMock;
129+
private $attributeGroupMock;
130130

131131
/**
132132
* @var SearchResultsInterface|\PHPUnit_Framework_MockObject_MockObject
133133
*/
134-
protected $searchResultsMock;
134+
private $searchResultsMock;
135135

136136
/**
137137
* @var Attribute|\PHPUnit_Framework_MockObject_MockObject
138138
*/
139-
protected $eavAttributeMock;
139+
private $eavAttributeMock;
140140

141141
protected function setUp()
142142
{
@@ -328,7 +328,7 @@ public function testModifyData()
328328
->willReturn([]);
329329
$this->eavAttributeMock->expects($this->once())
330330
->method('getFrontendInput')
331-
->willReturn(ProductAttributeInterface::CODE_PRICE);
331+
->willReturn('price');
332332
$this->eavAttributeMock->expects($this->any())
333333
->method('getAttributeCode')
334334
->willReturn(ProductAttributeInterface::CODE_PRICE);

app/code/Magento/Msrp/Test/Unit/Ui/DataProvider/Product/Form/Modifier/MsrpTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class MsrpTest extends AbstractModifierTest
1717
/**
1818
* @var MsrpConfig|\PHPUnit_Framework_MockObject_MockObject
1919
*/
20-
protected $msrpConfigMock;
20+
private $msrpConfigMock;
2121

2222
protected function setUp()
2323
{

0 commit comments

Comments
 (0)