Skip to content

Commit 057c13d

Browse files
author
Graham Wharton
committed
Resolved test failures
1 parent c764ca3 commit 057c13d

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

app/code/Magento/Email/Model/AbstractTemplate.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ public function __construct(
215215
$this->templateFactory = $templateFactory;
216216
$this->filterManager = $filterManager;
217217
$this->urlModel = $urlModel;
218-
$this->fileStorageDatabase = $fileStorageDatabase ?: \Magento\Framework\App\ObjectManager::getInstance()->get(Database::class);
218+
$this->fileStorageDatabase = $fileStorageDatabase ?:
219+
\Magento\Framework\App\ObjectManager::getInstance()->get(Database::class);
219220
parent::__construct($context, $registry, null, null, $data);
220221
}
221222

app/code/Magento/Email/Test/Unit/Model/BackendTemplateTest.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ class BackendTemplateTest extends \PHPUnit\Framework\TestCase
4646
*/
4747
private $serializerMock;
4848

49+
/**
50+
* @var \Magento\MediaStorage\Helper\File\Storage\Database|\PHPUnit_Framework_MockObject_MockObject
51+
*/
52+
private $databaseHelperMock;
53+
4954
protected function setUp()
5055
{
5156
$helper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -56,6 +61,7 @@ protected function setUp()
5661
$this->structureMock = $this->createMock(\Magento\Config\Model\Config\Structure::class);
5762
$this->structureMock->expects($this->any())->method('getFieldPathsByAttribute')->willReturn(['path' => 'test']);
5863

64+
$this->databaseHelperMock = $this->createMock(\Magento\MediaStorage\Helper\File\Storage\Database::class);
5965
$this->resourceModelMock = $this->createMock(\Magento\Email\Model\ResourceModel\Template::class);
6066
$this->resourceModelMock->expects($this->any())
6167
->method('getSystemConfigByPathsAndTemplateId')
@@ -64,8 +70,18 @@ protected function setUp()
6470
$objectManagerMock = $this->createMock(\Magento\Framework\ObjectManagerInterface::class);
6571
$objectManagerMock->expects($this->any())
6672
->method('get')
67-
->with(\Magento\Email\Model\ResourceModel\Template::class)
68-
->will($this->returnValue($this->resourceModelMock));
73+
->willReturnCallback(
74+
function ($value) {
75+
switch($value) {
76+
case \Magento\MediaStorage\Helper\File\Storage\Database::class:
77+
return ($this->databaseHelperMock);
78+
case \Magento\Email\Model\ResourceModel\Template::class:
79+
return ($this->resourceModelMock);
80+
default:
81+
return(NULL);
82+
}
83+
}
84+
);
6985

7086
\Magento\Framework\App\ObjectManager::setInstance($objectManagerMock);
7187

app/code/Magento/Email/composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"magento/module-config": "*",
1313
"magento/module-store": "*",
1414
"magento/module-theme": "*",
15+
"magento/module-media-storage": "*",
1516
"magento/module-variable": "*"
1617
},
1718
"suggest": {

0 commit comments

Comments
 (0)