MAGETWO-91440: Unassigned Attribute Values Render as N/A in Product Comparison block

cpartica · cpartica · commit 04b3d469f70f · 2018-05-24T10:57:08.000-05:00
- removing if that doesn't check the first item
diff --git a/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php b/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php
@@ -221,12 +221,9 @@ public function getProductAttributeValue($product, $attribute)
      */
     public function hasAttributeValueForProducts($attribute)
     {
-        $index = 0;
         foreach ($this->getItems() as $item) {
-            if ($index++ != 0) {
-                if ($item->hasData($attribute->getAttributeCode())) {
-                    return true;
-                }
+            if ($item->hasData($attribute->getAttributeCode())) {
+                return true;
             }
         }
         return false;

Original file line number	Diff line number	Diff line change
`@@ -221,12 +221,9 @@ public function getProductAttributeValue($product, $attribute)`
`221`	`221`	`*/`
`222`	`222`	`public function hasAttributeValueForProducts($attribute)`
`223`	`223`	`{`
`224`		`- $index = 0;`
`225`	`224`	`foreach ($this->getItems() as $item) {`
`226`		`- if ($index++ != 0) {`
`227`		`- if ($item->hasData($attribute->getAttributeCode())) {`
`228`		`- return true;`
`229`		`- }`
	`225`	`+ if ($item->hasData($attribute->getAttributeCode())) {`
	`226`	`+ return true;`
`230`	`227`	`}`
`231`	`228`	`}`
`232`	`229`	`return false;`