Skip to content

Commit 04b2f8b

Browse files
committed
ACP2E-94: When product is removed in Multiaddress checkout, the address dropdown value changes to default of all product.
IT for test coverage implemented-static and semantic version errors fixed
1 parent c2467f2 commit 04b2f8b

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

app/code/Magento/Quote/Model/Quote.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class Quote extends AbstractExtensibleModel implements \Magento\Quote\Api\Data\C
112112
/**
113113
* Checkout login method key
114114
*/
115-
protected const CHECKOUT_METHOD_LOGIN_IN = 'login_in';
115+
public const CHECKOUT_METHOD_LOGIN_IN = 'login_in';
116116

117117
/**
118118
* @var string

dev/tests/integration/testsuite/Magento/Quote/Model/QuoteTest.php

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -778,15 +778,15 @@ public function testIsMultiShippingModeEnabledAfterQuoteItemRemoved(): void
778778
$session->replaceQuote($quote);
779779
$items = $quote->getAllItems();
780780
$idToDelete = null;
781-
foreach($items as $item) {
781+
foreach ($items as $item) {
782782
if (!$item->getProduct()->isVirtual() && $item->getQty() == 1) {
783783
$idToDelete = $item->getId();
784784
}
785785
}
786786

787787
if (!is_null($idToDelete)) {
788788
$quoteShippingAddresses = $quote->getAllShippingAddresses();
789-
foreach($quoteShippingAddresses as $shippingAddress) {
789+
foreach ($quoteShippingAddresses as $shippingAddress) {
790790
if ($shippingAddress->getItemById($idToDelete)) {
791791
$shippingAddress->removeItem($idToDelete);
792792
$shippingAddress->setCollectShippingRates(true);
@@ -797,11 +797,16 @@ public function testIsMultiShippingModeEnabledAfterQuoteItemRemoved(): void
797797
}
798798
}
799799
$quote->removeItem($idToDelete);
800-
$this->assertEquals(1, $quote->getIsMultiShipping(),
801-
"Multi-shipping mode is disabled after quote item removal");
800+
$this->assertEquals(
801+
1,
802+
$quote->getIsMultiShipping(),
803+
"Multi-shipping mode is disabled after quote item removal"
804+
);
802805
} else {
803-
$this->assertTrue(!is_null($idToDelete),
804-
"No Simple Product item with qty 1 to delete exists");
806+
$this->assertTrue(
807+
!is_null($idToDelete),
808+
"No Simple Product item with qty 1 to delete exists"
809+
);
805810
}
806811
}
807812
}

0 commit comments

Comments
 (0)