MAGETWO-69828: [GitHub] Concurrent checkouts can lead to negative stock #6363

Author: svitja

app/code/Magento/CatalogInventory/Model/ResourceModel/Stock.php

@@ -119,7 +119,7 @@ protected function _construct()
      * @param int $websiteId
      * @return array
      */
-    public function lockProductsStock(array $productIds, $websiteId)
+    public function lockProductsStock(array $productIds, int $websiteId)
     {
         if (empty($productIds)) {
             return [];

app/code/Magento/CatalogInventory/Test/Unit/Model/ResourceModel/StockTest.php

@@ -118,7 +118,7 @@ protected function setUp()
      *
      * @return void
      */
-    public function testLockProductsStock($websiteId, array $productIds, array $products, array $result)
+    public function testLockProductsStock(int $websiteId, array $productIds, array $products, array $result)
     {
         $this->selectMock->expects($this->exactly(2))
             ->method('from')
@@ -178,7 +178,7 @@ public function testLockProductsStock($websiteId, array $productIds, array $prod
     /**
      * @return array
      */
-    public function productsDataProvider()
+    public function productsDataProvider(): array
     {
         return [
             [

app/code/Magento/CatalogInventory/Test/Unit/Model/StockManagementTest.php

@@ -236,7 +236,7 @@ public function testRegisterProductsSaleException(array $items, array $lockedIte
     /**
      * @return array
      */
-    public function productsWithCorrectQtyDataProvider()
+    public function productsWithCorrectQtyDataProvider(): array
     {
         return [
             [
@@ -276,7 +276,7 @@ public function productsWithCorrectQtyDataProvider()
     /**
      * @return array
      */
-    public function productsWithIncorrectQtyDataProvider()
+    public function productsWithIncorrectQtyDataProvider(): array
     {
         return [
             [