Skip to content

Commit 0455635

Browse files
committed
MAGETWO-88992: Broken image in Schedule update.
1 parent df09179 commit 0455635

File tree

2 files changed

+7
-25
lines changed
  • app/code/Magento/Catalog

2 files changed

+7
-25
lines changed

app/code/Magento/Catalog/Model/Category/Attribute/Backend/Image.php

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ class Image extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend
5252
*/
5353
private $imageUploader;
5454

55-
/**
56-
* @var string
57-
*/
58-
private $additionalData = '_additional_data_';
59-
6055
/**
6156
* Image constructor.
6257
*
@@ -85,9 +80,9 @@ public function beforeSave($object)
8580
{
8681
$attributeName = $this->getAttribute()->getName();
8782
$value = $object->getData($attributeName);
83+
$imageName = $this->getUploadedImageName($value);
8884

89-
if ($imageName = $this->getUploadedImageName($value)) {
90-
$object->setData($this->additionalData . $attributeName, $value);
85+
if ($imageName) {
9186
$object->setData($attributeName, $imageName);
9287
} else if (!is_string($value)) {
9388
$object->setData($attributeName, '');
@@ -130,27 +125,15 @@ private function getImageUploader()
130125
}
131126

132127
/**
133-
* Check if temporary file is available for new image upload.
134-
*
135-
* @param array $value
136-
* @return bool
137-
*/
138-
private function isTmpFileAvailable($value)
139-
{
140-
return is_array($value) && isset($value[0]['tmp_name']);
141-
}
142-
143-
/**
144-
* Save uploaded file and set its name to category
128+
* Save uploaded file and set its name to category.
145129
*
146130
* @param \Magento\Framework\DataObject $object
147131
* @return \Magento\Catalog\Model\Category\Attribute\Backend\Image
148132
*/
149133
public function afterSave($object)
150134
{
151-
$value = $object->getData($this->additionalData . $this->getAttribute()->getName());
152-
153-
if ($this->isTmpFileAvailable($value) && $imageName = $this->getUploadedImageName($value)) {
135+
$imageName = $object->getData($this->getAttribute()->getName(), null);
136+
if ($imageName) {
154137
try {
155138
$this->getImageUploader()->moveFileFromTmp($imageName);
156139
} catch (\Exception $e) {

app/code/Magento/Catalog/Test/Unit/Model/Category/Attribute/Backend/ImageTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,7 @@ public function testAfterSave()
164164

165165
$object = new \Magento\Framework\DataObject(
166166
[
167-
'test_attribute' => 'test1234.jpg',
168-
'_additional_data_test_attribute' => [['name' => 'test1234.jpg', 'tmp_name' => 'test-test-1234']]
167+
'test_attribute' => 'test1234.jpg'
169168
]
170169
);
171170
$model->afterSave($object);
@@ -208,7 +207,7 @@ public function testAfterSaveWithExceptions()
208207
->with($this->equalTo($exception));
209208
$object = new \Magento\Framework\DataObject(
210209
[
211-
'_additional_data_test_attribute' => [['name' => 'test1234.jpg', 'tmp_name' => 'test-test-1234']]
210+
'test_attribute' => 'test1234.jpg'
212211
]
213212
);
214213
$model->afterSave($object);

0 commit comments

Comments
 (0)