Merge pull request #5095 from magento-performance/MC-23411

[Performance] Random failure of PAT builds

Author: duhon

setup/src/Magento/Setup/Fixtures/_files/dictionary.csv

@@ -7370,4 +7370,4 @@ Gregory
 pine
 borrowed
 bow
-disturbing
+disturbing

setup/src/Magento/Setup/Model/Address/AddressDataGenerator.php

@@ -18,7 +18,7 @@ class AddressDataGenerator
     public function generateAddress()
     {
         return [
-            'postcode' => random_int(10000, 99999)
+            'postcode' => mt_rand(10000, 99999)
         ];
     }
 }

setup/src/Magento/Setup/Model/DataGenerator.php

@@ -4,11 +4,11 @@
  * See COPYING.txt for license details.
  */
 
-/**
- * A custom adapter that allows generating arbitrary descriptions
- */
 namespace Magento\Setup\Model;
 
+/**
+ * A custom adapter that allows generating arbitrary descriptions.
+ */
 class DataGenerator
 {
     /**
@@ -67,12 +67,12 @@ protected function readData()
      */
     public function generate($minAmountOfWords, $maxAmountOfWords, $key = null)
     {
-        $numberOfWords = random_int($minAmountOfWords, $maxAmountOfWords);
+        $numberOfWords = mt_rand($minAmountOfWords, $maxAmountOfWords);
         $result = '';
 
         if ($key === null || !array_key_exists($key, $this->generatedValues)) {
             for ($i = 0; $i < $numberOfWords; $i++) {
-                $result .= ' ' . $this->dictionaryData[random_int(0, count($this->dictionaryData) - 1)];
+                $result .= ' ' . $this->dictionaryData[mt_rand(0, count($this->dictionaryData) - 1)];
             }
             $result = trim($result);
 

setup/src/Magento/Setup/Model/Description/DescriptionGenerator.php

@@ -63,7 +63,7 @@ public function generate()
      */
     private function generateRawDescription()
     {
-        $paragraphsCount = random_int(
+        $paragraphsCount = mt_rand(
             $this->descriptionConfig['paragraphs']['count-min'],
             $this->descriptionConfig['paragraphs']['count-max']
         );

setup/src/Magento/Setup/Model/Description/DescriptionParagraphGenerator.php

@@ -39,7 +39,7 @@ public function __construct(
      */
     public function generate()
     {
-        $sentencesCount = random_int(
+        $sentencesCount = mt_rand(
             $this->paragraphConfig['sentences']['count-min'],
             $this->paragraphConfig['sentences']['count-max']
         );

setup/src/Magento/Setup/Model/Description/DescriptionSentenceGenerator.php

@@ -39,7 +39,7 @@ public function __construct(
      */
     public function generate()
     {
-        $sentenceWordsCount = random_int(
+        $sentenceWordsCount = mt_rand(
             $this->sentenceConfig['words']['count-min'],
             $this->sentenceConfig['words']['count-max']
         );

setup/src/Magento/Setup/Model/Description/Mixin/BoldMixin.php

@@ -48,7 +48,7 @@ public function apply($text)
 
         return $this->wordWrapper->wrapWords(
             $text,
-            $this->randomWordSelector->getRandomWords($rawText, random_int(5, 8)),
+            $this->randomWordSelector->getRandomWords($rawText, mt_rand(5, 8)),
             '<b>%s</b>'
         );
     }

setup/src/Magento/Setup/Model/Description/Mixin/Helper/RandomWordSelector.php

@@ -27,7 +27,7 @@ public function getRandomWords($source, $count)
         $randWords = [];
         $wordsSize = count($words);
         while ($count) {
-            $randWords[] = $words[random_int(0, $wordsSize - 1)];
+            $randWords[] = $words[mt_rand(0, $wordsSize - 1)];
             $count--;
         }
 

setup/src/Magento/Setup/Model/Description/Mixin/ItalicMixin.php

@@ -48,7 +48,7 @@ public function apply($text)
 
         return $this->wordWrapper->wrapWords(
             $text,
-            $this->randomWordSelector->getRandomWords($rawText, random_int(5, 8)),
+            $this->randomWordSelector->getRandomWords($rawText, mt_rand(5, 8)),
             '<i>%s</i>'
         );
     }

setup/src/Magento/Setup/Model/Description/Mixin/SpanMixin.php

@@ -48,7 +48,7 @@ public function apply($text)
 
         return $this->wordWrapper->wrapWords(
             $text,
-            $this->randomWordSelector->getRandomWords($rawText, random_int(5, 8)),
+            $this->randomWordSelector->getRandomWords($rawText, mt_rand(5, 8)),
             '<span>%s</span>'
         );
     }