ACP2E-963: setup:upgrade is changing indexer mode to save from schedule slowing it down immensely

Author: Anna Bukatar

lib/internal/Magento/Framework/Mview/TriggerCleaner.php

@@ -10,6 +10,8 @@
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\Mview\View\CollectionFactory;
 use Magento\Framework\Mview\View\StateInterface;
+use Magento\Framework\Mview\View\Subscription;
+use Magento\Framework\DB\Ddl\Trigger;
 
 /**
  * Class for removing old triggers that were created by mview
@@ -54,28 +56,47 @@ public function __construct(
      */
     public function removeTriggers(): bool
     {
+        //Get all existing triggers from the DB
+        $triggers = $this->getAllTriggers();
+        $processedTriggers = [];
+
         // Get list of views that are enabled
         $viewCollection = $this->viewCollectionFactory->create();
         $viewList = $viewCollection->getViewsByStateMode(StateInterface::MODE_ENABLED);
 
-        // Unsubscribe existing view to remove triggers from db
+        // Check triggers declaration for the enabled views and update them if any changes
         foreach ($viewList as $view) {
-            $view->unsubscribe();
+            $subscriptions = $view->getSubscriptions();
+            foreach ($subscriptions as $subscriptionConfig) {
+                /* @var $subscription Subscription */
+                $subscription = $view->initSubscriptionInstance($subscriptionConfig);
+                $viewTriggers = $subscription->create(false)->getTriggers();
+                foreach ($viewTriggers as $viewTrigger) {
+                    if (array_key_exists($viewTrigger->getName(), $triggers)) {
+                        foreach ($this->getStatementsFromViewTrigger($viewTrigger) as $statement) {
+                            if (!empty($statement) &&
+                                !str_contains($triggers[$viewTrigger->getName()]['ACTION_STATEMENT'],$statement)
+                            ) {
+                                $subscription->saveTrigger($viewTrigger);
+                                break;
+                            }
+                        }
+                    } else {
+                        $subscription->saveTrigger($viewTrigger);
+                    }
+                    $processedTriggers[$viewTrigger->getName()] = true;
+                }
+            }
         }
 
         // Remove any remaining triggers from db that are not linked to a view
-        $triggerTableNames = $this->getTableNamesWithTriggers();
-        foreach ($triggerTableNames as $tableName) {
-            $view = $this->createViewByTableName($tableName);
+        $remainingTriggers = array_diff_key($triggers, $processedTriggers);
+        foreach ($remainingTriggers as $trigger) {
+            $view = $this->createViewByTableName($trigger['EVENT_OBJECT_TABLE']);
             $view->unsubscribe();
             $view->getState()->delete();
         }
 
-        // Restore the previous state of the views to add triggers back to db
-        foreach ($viewList as $view) {
-            $view->subscribe();
-        }
-
         return true;
     }
 
@@ -84,18 +105,17 @@ public function removeTriggers(): bool
      *
      * @return array
      */
-    private function getTableNamesWithTriggers(): array
+    private function getAllTriggers(): array
     {
         $connection = $this->resource->getConnection();
         $dbName = $this->resource->getSchemaName(ResourceConnection::DEFAULT_CONNECTION);
         $sql = $connection->select()
             ->from(
                 ['information_schema.TRIGGERS'],
-                ['EVENT_OBJECT_TABLE']
+                ['TRIGGER_NAME', 'ACTION_STATEMENT', 'EVENT_OBJECT_TABLE']
             )
-            ->distinct(true)
             ->where('TRIGGER_SCHEMA = ?', $dbName);
-        return $connection->fetchCol($sql);
+        return $connection->fetchAssoc($sql);
     }
 
     /**
@@ -124,4 +144,26 @@ private function createViewByTableName(string $tableName): ViewInterface
 
         return $view;
     }
+
+    /**
+     * Get trigger statements for further analyze
+     *
+     * @param Trigger $trigger
+     * @return string[]
+     */
+    private function getStatementsFromViewTrigger(Trigger $trigger): array
+    {
+        $statements = $trigger->getStatements();
+
+        //Check for staged entity attribute subscription
+        $statement = array_shift($statements);
+        if (str_contains($statement, 'SET')) {
+            $splitStatements = explode(PHP_EOL, $statement);
+            $statements += $splitStatements;
+        } else {
+            array_unshift($statements, $statement);
+        }
+
+        return $statements;
+    }
 }

lib/internal/Magento/Framework/Mview/View.php

@@ -465,7 +465,7 @@ public function getChangelog()
      * @param array $subscriptionConfig
      * @return SubscriptionInterface
      */
-    private function initSubscriptionInstance(array $subscriptionConfig): SubscriptionInterface
+    public function initSubscriptionInstance(array $subscriptionConfig): SubscriptionInterface
     {
         return $this->subscriptionFactory->create(
             [

lib/internal/Magento/Framework/Mview/View/Subscription.php

@@ -82,6 +82,11 @@ class Subscription implements SubscriptionInterface
      */
     private $mviewConfig;
 
+    /**
+     * @var Trigger[]
+     */
+    private $triggers = [];
+
     /**
      * @param ResourceConnection $resource
      * @param TriggerFactory $triggerFactory
@@ -121,7 +126,7 @@ public function __construct(
      *
      * @return SubscriptionInterface
      */
-    public function create()
+    public function create(bool $save = true)
     {
         foreach (Trigger::getListOfEvents() as $event) {
             $triggerName = $this->getAfterEventTriggerName($event);
@@ -139,14 +144,39 @@ public function create()
                 /** @var ViewInterface $view */
                 $trigger->addStatement($this->buildStatement($event, $view));
             }
+            $this->triggers[] = $trigger;
 
-            $this->connection->dropTrigger($trigger->getName());
-            $this->connection->createTrigger($trigger);
+            if ($save) {
+                $this->saveTrigger($trigger);
+            }
         }
 
         return $this;
     }
 
+    /**
+     * Get all triggers for the subscription
+     *
+     * @return Trigger[]
+     */
+    public function getTriggers(): array
+    {
+        return $this->triggers;
+    }
+
+    /**
+     * Save a trigger to the DB
+     *
+     * @param Trigger $trigger
+     * @return void
+     * @throws \Zend_Db_Exception
+     */
+    public function saveTrigger(Trigger $trigger): void
+    {
+        $this->connection->dropTrigger($trigger->getName());
+        $this->connection->createTrigger($trigger);
+    }
+
     /**
      * Remove subscription
      *