MAGETWO-68928: Fatal error after disabling module

Author: shiftedreality

lib/internal/Magento/Framework/Console/Cli.php

@@ -66,23 +66,33 @@ class Cli extends Console\Application
     /**
      * @param string $name the application name
      * @param string $version the application version
+     * @SuppressWarnings(PHPMD.ExitExpression)
      */
     public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN')
     {
-        $configuration = require BP . '/setup/config/application.config.php';
-        $bootstrapApplication = new Application();
-        $application = $bootstrapApplication->bootstrap($configuration);
-        $this->serviceManager = $application->getServiceManager();
-
-        $this->assertCompilerPreparation();
-        $this->initObjectManager();
-        $this->assertGenerationPermissions();
-
-        if ($version == 'UNKNOWN') {
-            $directoryList = new DirectoryList(BP);
-            $composerJsonFinder = new ComposerJsonFinder($directoryList);
-            $productMetadata = new ProductMetadata($composerJsonFinder);
-            $version = $productMetadata->getVersion();
+        try {
+            $configuration = require BP . '/setup/config/application.config.php';
+            $bootstrapApplication = new Application();
+            $application = $bootstrapApplication->bootstrap($configuration);
+            $this->serviceManager = $application->getServiceManager();
+
+            $this->assertCompilerPreparation();
+            $this->initObjectManager();
+            $this->assertGenerationPermissions();
+
+            if ($version == 'UNKNOWN') {
+                $directoryList = new DirectoryList(BP);
+                $composerJsonFinder = new ComposerJsonFinder($directoryList);
+                $productMetadata = new ProductMetadata($composerJsonFinder);
+                $version = $productMetadata->getVersion();
+            }
+        } catch (\Exception $exception) {
+            $output = new Console\Output\ConsoleOutput();
+            $output->writeln(
+                '<error>' . $exception->getMessage() . '</error>'
+            );
+
+            exit(static::RETURN_FAILURE);
         }
 
         parent::__construct($name, $version);

lib/internal/Magento/Framework/Console/Exception/GenerationDirectoryAccessException.php

@@ -9,6 +9,9 @@
 use Magento\Framework\Exception\FileSystemException;
 use Magento\Framework\Phrase;
 
+/**
+ * The default exception for missing write permissions on compilation generated folder.
+ */
 class GenerationDirectoryAccessException extends FileSystemException
 {
     /**
@@ -18,7 +21,7 @@ public function __construct(Phrase $phrase = null, \Exception $cause = null, $co
     {
         $phrase = $phrase ?: new Phrase(
             'Command line user does not have read and write permissions on '
-            . $this->getDefaultDirectoryPath(DirectoryList::GENERATED_CODE) . ' directory. '
+            . $this->getDefaultDirectoryPath(DirectoryList::GENERATED) . ' directory. '
             . 'Please address this issue before using Magento command line.'
         );