MC-43189: [Graphql] Swatch Configurable option can be added to cart on any website

Author: dhorytskyi

app/code/Magento/ConfigurableProductGraphQl/Test/Unit/Model/Cart/BuyRequest/SuperAttributeDataProviderTest.php

@@ -7,15 +7,17 @@
 
 namespace Magento\ConfigurableProductGraphQl\Test\Unit\Model\Cart\BuyRequest;
 
+use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Product;
 use Magento\CatalogInventory\Api\StockStateInterface;
 use Magento\ConfigurableProductGraphQl\Model\Cart\BuyRequest\SuperAttributeDataProvider;
 use Magento\ConfigurableProductGraphQl\Model\Options\Collection as OptionCollection;
+use Magento\Framework\EntityManager\EntityMetadataInterface;
 use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Framework\Stdlib\ArrayManager;
 use Magento\Quote\Model\Quote;
-use Magento\Store\Api\Data\StoreInterface;
+use Magento\Store\Model\Store;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -50,7 +52,7 @@ class SuperAttributeDataProviderTest extends TestCase
     private $stockState;
 
     /**
-     * @var SuperAttributeDataProvider|MockObject
+     * @var SuperAttributeDataProvider
      */
     private $superAttributeDataProvider;
 
@@ -59,22 +61,11 @@ class SuperAttributeDataProviderTest extends TestCase
      */
     protected function setUp(): void
     {
-        $this->arrayManager = $this->getMockBuilder(ArrayManager::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->productRepository = $this->getMockBuilder(ProductRepositoryInterface::class)
-            ->disableOriginalConstructor()
-            ->getMockForAbstractClass();
+        $this->arrayManager = $this->createMock(ArrayManager::class);
+        $this->productRepository = $this->createMock(ProductRepositoryInterface::class);
         $this->optionCollection = $this->createMock(OptionCollection::class);
-        $this->metadataPool = $this->getMockBuilder(MetadataPool::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['getMetadata'])
-            ->addMethods(['getLinkField'])
-            ->getMock();
-        $this->stockState = $this->getMockBuilder(StockStateInterface::class)
-            ->disableOriginalConstructor()
-            ->addMethods(['getHasError'])
-            ->getMockForAbstractClass();
+        $this->metadataPool = $this->createMock(MetadataPool::class);
+        $this->stockState = $this->createMock(StockStateInterface::class);
 
         $this->superAttributeDataProvider = new SuperAttributeDataProvider(
             $this->arrayManager,
@@ -90,9 +81,7 @@ protected function setUp(): void
      */
     public function testExecute(): void
     {
-        $quoteMock = $this->getMockBuilder(Quote::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $quoteMock = $this->createMock(Quote::class);
         $cartItemData = [
             'data' => [
                 'quantity' => 2.0,
@@ -116,19 +105,19 @@ public function testExecute(): void
                 $quoteMock,
             );
 
-        $storeMock = $this->getMockBuilder(StoreInterface::class)
-            ->disableOriginalConstructor()
-            ->addMethods(['getWebsite'])
-            ->getMockForAbstractClass();
-        $storeMock->expects($this->once())->method('getWebsiteId')->willReturn(1);
+        $websiteId = 1;
+        $storeMock = $this->createMock(Store::class);
+        $storeMock->expects($this->atLeastOnce())
+            ->method('getWebsiteId')
+            ->willReturn($websiteId);
         $storeMock->expects($this->never())->method('getWebsite');
         $quoteMock->expects($this->atLeastOnce())
             ->method('getStore')
             ->willReturn($storeMock);
 
         $productMock = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
-            ->onlyMethods(['getId', 'getExtensionAttributes', 'getData'])
+            ->onlyMethods(['getId', 'getExtensionAttributes', 'getData', 'getWebsiteIds'])
             ->addMethods(['getConfigurableProductLinks'])
             ->getMock();
         $productMock->method('getId')
@@ -139,16 +128,20 @@ public function testExecute(): void
             ->willReturn([1]);
         $productMock->method('getData')
             ->willReturn(1);
+        $productMock->method('getWebsiteIds')
+            ->willReturn([$websiteId]);
         $this->productRepository->method('get')
             ->willReturn($productMock);
+        $checkResult = new \Magento\Framework\DataObject();
+        $checkResult->setHasError(false);
         $this->stockState->method('checkQuoteItemQty')
-            ->willReturnSelf();
-        $this->stockState->method('getHasError')
-            ->willReturn(false);
+            ->willReturn($checkResult);
+        $productMetadata = $this->createMock(EntityMetadataInterface::class);
+        $productMetadata->method('getLinkField')
+            ->willReturn('entity_id');
         $this->metadataPool->method('getMetadata')
-            ->willReturnSelf();
-        $this->metadataPool->method('getLinkField')
-            ->willReturnSelf();
+            ->with(ProductInterface::class)
+            ->willReturn($productMetadata);
         $this->optionCollection->method('getAttributesByProductId')
             ->willReturn([
                 [

dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartTest.php

@@ -251,7 +251,6 @@ public function testAddNonExistentConfigurableProductParentToCart()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable_sku.php
-     * @magentoApiDataFixture Magento/Checkout/_files/active_quote.php
      * @magentoApiDataFixture Magento/Checkout/_files/active_quote_not_default_website.php
      */
     public function testAddConfigurableProductNotAssignedToWebsite()
@@ -291,13 +290,33 @@ public function testAddNonExistentConfigurableProductVariationToCart()
 
         $this->expectException(Exception::class);
         $this->expectExceptionMessage(
-            'Could not add the product with SKU configurable to the shopping cart: The product that was requested ' .
-            'doesn\'t exist. Verify the product and try again.'
+            'Could not add the product with SKU configurable to the shopping cart: Could not find specified product.'
         );
 
         $this->graphQlMutation($query);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/ConfigurableProduct/_files/configurable_product_only_parent_two_websites.php
+     * @magentoApiDataFixture Magento/Checkout/_files/active_quote_not_default_website.php
+     */
+    public function testAddUnassignedToWebsiteConfigurableProductVariationToCart()
+    {
+        $this->expectException(Exception::class);
+        $this->expectExceptionMessage(
+            'Could not add the product with SKU configurable to the shopping cart: Could not find specified product.'
+        );
+
+        $reservedOrderId = 'test_order_2';
+        $parentSku = 'configurable';
+        $sku = 'simple_20';
+        $headerMap = ['Store' => 'fixture_second_store'];
+
+        $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute($reservedOrderId);
+        $query = $this->getQuery($maskedQuoteId, $parentSku, $sku, 1);
+        $this->graphQlMutation($query, [], '', $headerMap);
+    }
+
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable_disable_first_child.php
      * @magentoApiDataFixture Magento/Checkout/_files/active_quote.php

dev/tests/integration/testsuite/Magento/ConfigurableProduct/_files/configurable_product_only_parent_two_websites.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Store\Api\WebsiteRepositoryInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
+
+Resolver::getInstance()->requireDataFixture('Magento/ConfigurableProduct/_files/product_configurable_sku.php');
+Resolver::getInstance()->requireDataFixture('Magento/Store/_files/second_website_with_two_stores.php');
+
+$websiteRepository = Bootstrap::getObjectManager()->get(WebsiteRepositoryInterface::class);
+$secondWebsite = $websiteRepository->get('test');
+
+$productRepository = Bootstrap::getObjectManager()->get(ProductRepositoryInterface::class);
+$configurableProduct = $productRepository->get('configurable');
+$configurableProduct->setWebsiteIds(array_merge($configurableProduct->getWebsiteIds(), [$secondWebsite->getId()]));
+$productRepository->save($configurableProduct);