Skip to content

Commit 025c1bb

Browse files
ENGCOM-5713: Resolve undefined variable when call getPdf() in app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php #24282
- Merge Pull Request #24282 from edenduong/magento2:2.3-bugfix/undefined_variable_get_pdf - Merged commits: 1. d610ae7 2. c43eac4
2 parents ad44545 + c43eac4 commit 025c1bb

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
7+
declare(strict_types=1);
8+
69
namespace Magento\Sales\Model\Order\Pdf;
710

811
/**
912
* Sales Order Creditmemo PDF model
13+
*
1014
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
1115
*/
1216
class Creditmemo extends AbstractPdf
@@ -180,11 +184,11 @@ public function getPdf($creditmemos = [])
180184
}
181185
/* Add totals */
182186
$this->insertTotals($page, $creditmemo);
187+
if ($creditmemo->getStoreId()) {
188+
$this->_localeResolver->revert();
189+
}
183190
}
184191
$this->_afterGetPdf();
185-
if ($creditmemo->getStoreId()) {
186-
$this->_localeResolver->revert();
187-
}
188192
return $pdf;
189193
}
190194

0 commit comments

Comments
 (0)