Skip to content

Commit 01f0a76

Browse files
🔃 [EngCom] Public Pull Requests - 2.2-develop
Accepted Public Pull Requests: - #14923: Move customer.account.dashboard.info.extra block to contact information (by @JeroenVanLeusden) - #14939: Renamed "Add Block Names to Hints" config setting to represent what it actually does (by @chris-pook) - #14874: Fix infinite checkout loader when some script wasn't loaded correctly because of network error (by @vovayatsyuk)
2 parents 9cfd602 + 5613381 commit 01f0a76

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

app/code/Magento/Backend/etc/adminhtml/system.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
121121
</field>
122122
<field id="template_hints_blocks" translate="label" type="select" sortOrder="21" showInDefault="1" showInWebsite="1" showInStore="1">
123-
<label>Add Block Names to Hints</label>
123+
<label>Add Block Class Type to Hints</label>
124124
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
125125
</field>
126126
</group>

app/code/Magento/Customer/view/frontend/templates/account/dashboard/info.phtml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<?= $block->escapeHtml($block->getName()) ?><br>
2121
<?= $block->escapeHtml($block->getCustomer()->getEmail()) ?><br>
2222
</p>
23+
<?= $block->getChildHtml('customer.account.dashboard.info.extra'); ?>
2324
</div>
2425
<div class="box-actions">
2526
<a class="action edit" href="<?= $block->escapeUrl($block->getUrl('customer/account/edit')) ?>">
@@ -43,8 +44,6 @@
4344
<?= $block->escapeHtml(__('You aren\'t subscribed to our newsletter.')) ?>
4445
<?php endif; ?>
4546
</p>
46-
<?php /* Extensions placeholder */ ?>
47-
<?= $block->getChildHtml('customer.account.dashboard.info.extra') ?>
4847
</div>
4948
<div class="box-actions">
5049
<a class="action edit" href="<?= $block->escapeUrl($block->getUrl('newsletter/manage')) ?>"><span><?= $block->escapeHtml(__('Edit')) ?></span></a>

lib/web/mage/requirejs/resolver.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,28 @@ define([
2727
return !!_.findWhere(callbacks, callback);
2828
}
2929

30+
/**
31+
* Checks if provided module is rejected during load.
32+
*
33+
* @param {Object} module - Module to be checked.
34+
* @return {Boolean}
35+
*/
36+
function isRejected(module) {
37+
return registry[module.id] && registry[module.id].error;
38+
}
39+
3040
/**
3141
* Checks if provided module has unresolved dependencies.
3242
*
3343
* @param {Object} module - Module to be checked.
3444
* @returns {Boolean}
3545
*/
3646
function isPending(module) {
37-
return !!module.depCount;
47+
if (!module.depCount) {
48+
return false;
49+
}
50+
51+
return module.depCount > _.filter(module.depMaps, isRejected).length;
3852
}
3953

4054
/**

0 commit comments

Comments
 (0)