MAGETWO-32953: Fix Bamboo builds

marcozheng · marcozheng · commit 01b216eeb7e0 · 2015-01-27T14:17:21.000-06:00
- Fix PHPMD violations
diff --git a/app/code/Magento/Bundle/Model/Product/CatalogPrice.php b/app/code/Magento/Bundle/Model/Product/CatalogPrice.php
@@ -80,6 +80,7 @@ public function getCatalogPrice(\Magento\Catalog\Model\Product $product, $store
      *
      * @param \Magento\Catalog\Model\Product $product
      * @return null
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getCatalogRegularPrice(\Magento\Catalog\Model\Product $product)
     {
diff --git a/app/code/Magento/Bundle/Model/Product/Type.php b/app/code/Magento/Bundle/Model/Product/Type.php
@@ -588,6 +588,7 @@ public function updateQtyOption($options, \Magento\Framework\Object $option, $va
      * @param mixed $qty
      * @param \Magento\Catalog\Model\Product $product
      * @return int
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function prepareQuoteItemQty($qty, $product)
     {
@@ -1028,6 +1029,7 @@ public function hasOptions($product)
      * @param \Magento\Catalog\Model\Product $product
      * @return boolean true
      * @SuppressWarnings(PHPMD.BooleanGetMethodName)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getForceChildItemQtyChanges($product)
     {
@@ -1133,6 +1135,7 @@ public function getProductsToPurchaseByReqGroups($product)
      * @param  \Magento\Catalog\Model\Product $product
      * @param  \Magento\Framework\Object $buyRequest
      * @return array
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function processBuyRequest($product, $buyRequest)
     {
@@ -1165,6 +1168,7 @@ public function canConfigure($product)
      *
      * @param \Magento\Catalog\Model\Product $product
      * @return void
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function deleteTypeSpecificData(\Magento\Catalog\Model\Product $product)
     {
diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Price.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Price.php
@@ -109,6 +109,7 @@ protected function _getTaxObservingCode($attribute)
     /**
      * @param null|int|string $index
      * @return null|string
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getEscapedValue($index = null)
     {
diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/AbstractFilter.php b/app/code/Magento/Catalog/Model/Layer/Filter/AbstractFilter.php
@@ -128,6 +128,7 @@ public function getCleanValue()
      *
      * @param \Magento\Framework\App\RequestInterface $request
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function apply(\Magento\Framework\App\RequestInterface $request)
     {
diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Manual.php b/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Manual.php
@@ -49,6 +49,7 @@ public function __construct(
      * @param int[] $intervals
      * @param string $additionalRequestData
      * @return array
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getItemsData(array $intervals = [], $additionalRequestData = '')
     {
diff --git a/app/code/Magento/Catalog/Model/Layer/Search/CollectionFilter.php b/app/code/Magento/Catalog/Model/Layer/Search/CollectionFilter.php
@@ -49,6 +49,7 @@ public function __construct(
      * @param \Magento\Catalog\Model\Resource\Product\Collection $collection
      * @param \Magento\Catalog\Model\Category $category
      * @return void
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function filter(
         $collection,
diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/File/Validator.php b/app/code/Magento/Catalog/Model/Product/Option/Type/File/Validator.php
@@ -7,6 +7,9 @@
 
 use Magento\Framework\App\Filesystem\DirectoryList;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 abstract class Validator
 {
     /**
diff --git a/app/code/Magento/Catalog/Model/Resource/AbstractResource.php b/app/code/Magento/Catalog/Model/Resource/AbstractResource.php
@@ -345,6 +345,7 @@ protected function _insertAttribute($object, $attribute, $value)
      * @param mixed $valueId
      * @param mixed $value
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     protected function _updateAttribute($object, $attribute, $valueId, $value)
     {
@@ -490,6 +491,7 @@ protected function _getOrigObject($object)
      * @param AbstractAttribute $attribute
      * @param mixed $value
      * @return bool
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     protected function _isAttributeValueEmpty(AbstractAttribute $attribute, $value)
     {
diff --git a/app/code/Magento/Catalog/Model/Resource/Category/Attribute/Collection.php b/app/code/Magento/Catalog/Model/Resource/Category/Attribute/Collection.php
@@ -68,6 +68,7 @@ protected function _initSelect()
      *
      * @param int $typeId
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function setEntityTypeFilter($typeId)
     {
diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Collection.php b/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Collection.php
@@ -89,6 +89,7 @@ protected function _initSelect()
      *
      * @param  int $typeId
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function setEntityTypeFilter($typeId)
     {
diff --git a/app/code/Magento/CatalogUrlRewrite/Model/Category/Observer.php b/app/code/Magento/CatalogUrlRewrite/Model/Category/Observer.php
@@ -15,6 +15,9 @@
 use Magento\UrlRewrite\Model\UrlPersistInterface;
 use Magento\UrlRewrite\Service\V1\Data\UrlRewrite;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class Observer
 {
     /** @var \Magento\CatalogUrlRewrite\Model\Category\ChildrenCategoriesProvider */
diff --git a/app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php b/app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php
@@ -15,6 +15,9 @@
 use Magento\Store\Model\Store;
 use Magento\Framework\Model\AbstractModel;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class Group
 {
     /** @var UrlPersistInterface */
diff --git a/app/code/Magento/CatalogUrlRewrite/Model/Product/CurrentUrlRewritesRegenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/Product/CurrentUrlRewritesRegenerator.php
@@ -16,6 +16,9 @@
 use Magento\UrlRewrite\Service\V1\Data\UrlRewriteBuilder;
 use Magento\Framework\Store\StoreManagerInterface;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class CurrentUrlRewritesRegenerator
 {
     /** @var Product */
diff --git a/app/code/Magento/Checkout/Controller/Cart/Add.php b/app/code/Magento/Checkout/Controller/Cart/Add.php
@@ -13,6 +13,9 @@
 use Magento\Checkout\Model\Cart as CustomerCart;
 use Magento\Framework\Exception\NoSuchEntityException;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class Add extends \Magento\Checkout\Controller\Cart
 {
     /**
diff --git a/app/code/Magento/DesignEditor/Model/State.php b/app/code/Magento/DesignEditor/Model/State.php
@@ -7,6 +7,7 @@
 
 /**
  * Design editor state model
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class State
 {
diff --git a/app/code/Magento/Eav/Model/Resource/Attribute/Collection.php b/app/code/Magento/Eav/Model/Resource/Attribute/Collection.php
@@ -213,6 +213,7 @@ protected function _initSelect()
      *
      * @param  int $type
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function setEntityTypeFilter($type)
     {
diff --git a/app/code/Magento/Fedex/Model/Carrier.php b/app/code/Magento/Fedex/Model/Carrier.php
@@ -1533,6 +1533,7 @@ public function getContainerTypesFilter()
      *
      * @param \Magento\Framework\Object|null $params
      * @return array
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getDeliveryConfirmationTypes(\Magento\Framework\Object $params = null)
     {
diff --git a/app/code/Magento/Reports/Model/Resource/Refresh/Collection.php b/app/code/Magento/Reports/Model/Resource/Refresh/Collection.php
@@ -63,6 +63,7 @@ protected function _getUpdatedAt($reportCode)
      * @param bool $printQuery
      * @param bool $logQuery
      * @return $this
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function loadData($printQuery = false, $logQuery = false)
     {
diff --git a/app/code/Magento/Review/Model/Resource/Rating.php b/app/code/Magento/Review/Model/Resource/Rating.php
@@ -35,15 +35,13 @@ class Rating extends \Magento\Framework\Model\Resource\Db\AbstractDb
      * @param \Magento\Framework\App\Resource $resource
      * @param \Psr\Log\LoggerInterface $logger
      * @param \Magento\Framework\Module\Manager $moduleManager
-     * @param \Magento\Review\Helper\Data $ratingData
      * @param \Magento\Framework\Store\StoreManagerInterface $storeManager
      * @param \Magento\Review\Model\Resource\Review\Summary $reviewSummary
      */
     public function __construct(
         \Magento\Framework\App\Resource $resource,
         \Psr\Log\LoggerInterface $logger,
         \Magento\Framework\Module\Manager $moduleManager,
-        \Magento\Review\Helper\Data $ratingData,
         \Magento\Framework\Store\StoreManagerInterface $storeManager,
         \Magento\Review\Model\Resource\Review\Summary $reviewSummary
     ) {

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ public function getCatalogPrice(\Magento\Catalog\Model\Product $product, $store`
`80`	`80`	`*`
`81`	`81`	`* @param \Magento\Catalog\Model\Product $product`
`82`	`82`	`* @return null`
	`83`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`83`	`84`	`*/`
`84`	`85`	`public function getCatalogRegularPrice(\Magento\Catalog\Model\Product $product)`
`85`	`86`	`{`
Original file line number	Diff line number	Diff line change
`@@ -588,6 +588,7 @@ public function updateQtyOption($options, \Magento\Framework\Object $option, $va`
`588`	`588`	`* @param mixed $qty`
`589`	`589`	`* @param \Magento\Catalog\Model\Product $product`
`590`	`590`	`* @return int`
	`591`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`591`	`592`	`*/`
`592`	`593`	`public function prepareQuoteItemQty($qty, $product)`
`593`	`594`	`{`
`@@ -1028,6 +1029,7 @@ public function hasOptions($product)`
`1028`	`1029`	`* @param \Magento\Catalog\Model\Product $product`
`1029`	`1030`	`* @return boolean true`
`1030`	`1031`	`* @SuppressWarnings(PHPMD.BooleanGetMethodName)`
	`1032`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`1031`	`1033`	`*/`
`1032`	`1034`	`public function getForceChildItemQtyChanges($product)`
`1033`	`1035`	`{`
`@@ -1133,6 +1135,7 @@ public function getProductsToPurchaseByReqGroups($product)`
`1133`	`1135`	`* @param \Magento\Catalog\Model\Product $product`
`1134`	`1136`	`* @param \Magento\Framework\Object $buyRequest`
`1135`	`1137`	`* @return array`
	`1138`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`1136`	`1139`	`*/`
`1137`	`1140`	`public function processBuyRequest($product, $buyRequest)`
`1138`	`1141`	`{`
`@@ -1165,6 +1168,7 @@ public function canConfigure($product)`
`1165`	`1168`	`*`
`1166`	`1169`	`* @param \Magento\Catalog\Model\Product $product`
`1167`	`1170`	`* @return void`
	`1171`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`1168`	`1172`	`*/`
`1169`	`1173`	`public function deleteTypeSpecificData(\Magento\Catalog\Model\Product $product)`
`1170`	`1174`	`{`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ protected function _getTaxObservingCode($attribute)`
`109`	`109`	`/**`
`110`	`110`	`* @param null\|int\|string $index`
`111`	`111`	`* @return null\|string`
	`112`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`112`	`113`	`*/`
`113`	`114`	`public function getEscapedValue($index = null)`
`114`	`115`	`{`
Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ public function getCleanValue()`
`128`	`128`	`*`
`129`	`129`	`* @param \Magento\Framework\App\RequestInterface $request`
`130`	`130`	`* @return $this`
	`131`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`131`	`132`	`*/`
`132`	`133`	`public function apply(\Magento\Framework\App\RequestInterface $request)`
`133`	`134`	`{`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ public function __construct(`
`49`	`49`	`* @param int[] $intervals`
`50`	`50`	`* @param string $additionalRequestData`
`51`	`51`	`* @return array`
	`52`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`52`	`53`	`*/`
`53`	`54`	`public function getItemsData(array $intervals = [], $additionalRequestData = '')`
`54`	`55`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`use Magento\Framework\App\Filesystem\DirectoryList;`
`9`	`9`
	`10`	`+/**`
	`11`	`+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
	`12`	`+ */`
`10`	`13`	`abstract class Validator`
`11`	`14`	`{`
`12`	`15`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ protected function _initSelect()`
`68`	`68`	`*`
`69`	`69`	`* @param int $typeId`
`70`	`70`	`* @return $this`
	`71`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`71`	`72`	`*/`
`72`	`73`	`public function setEntityTypeFilter($typeId)`
`73`	`74`	`{`
Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ protected function _initSelect()`
`89`	`89`	`*`
`90`	`90`	`* @param int $typeId`
`91`	`91`	`* @return $this`
	`92`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`92`	`93`	`*/`
`93`	`94`	`public function setEntityTypeFilter($typeId)`
`94`	`95`	`{`