Added Test for Translation

Author: shikhamis11

app/code/Magento/StoreGraphQl/Controller/HttpHeaderProcessor/StoreProcessor.php

@@ -1,8 +1,10 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 declare(strict_types=1);
 
 namespace Magento\StoreGraphQl\Controller\HttpHeaderProcessor;
@@ -11,6 +13,8 @@
 use Magento\Store\Model\StoreManagerInterface;
 use Magento\Framework\App\Http\Context as HttpContext;
 use Magento\Store\Api\StoreCookieManagerInterface;
+use Magento\Framework\App\ObjectManager;
+use Magento\Framework\Locale\ResolverInterface;
 
 /**
  * Process the "Store" header entry
@@ -32,19 +36,27 @@ class StoreProcessor implements HttpHeaderProcessorInterface
      */
     private $storeCookieManager;
 
+    /**
+     * @var ResolverInterface
+     */
+    private $localeResolver;
+
     /**
      * @param StoreManagerInterface $storeManager
      * @param HttpContext $httpContext
      * @param StoreCookieManagerInterface $storeCookieManager
+     * @param ResolverInterface $localeResolver
      */
     public function __construct(
         StoreManagerInterface $storeManager,
         HttpContext $httpContext,
-        StoreCookieManagerInterface $storeCookieManager
+        StoreCookieManagerInterface $storeCookieManager,
+        ResolverInterface $localeResolver = null
     ) {
         $this->storeManager = $storeManager;
         $this->httpContext = $httpContext;
         $this->storeCookieManager = $storeCookieManager;
+        $this->localeResolver = $localeResolver ?: ObjectManager::getInstance()->get(ResolverInterface::class);
     }
 
     /**
@@ -60,9 +72,10 @@ public function processHeaderValue(string $headerValue): void
         if (!empty($headerValue)) {
             $storeCode = ltrim(rtrim($headerValue));
             if ($this->isStoreValid($storeCode)) {
+                $this->localeResolver->emulate($this->storeManager->getStore($storeCode)->getId());
                 $this->storeManager->setCurrentStore($storeCode);
                 $this->updateContext($storeCode);
-            }
+             }
         } elseif (!$this->isAlreadySet()) {
             $storeCode = $this->storeCookieManager->getStoreCodeFromCookie()
                 ?: $this->storeManager->getDefaultStoreView()->getCode();
@@ -77,7 +90,7 @@ public function processHeaderValue(string $headerValue): void
      * @param string $storeCode
      * @return void
      */
-    private function updateContext(string $storeCode) : void
+    private function updateContext(string $storeCode): void
     {
         $this->httpContext->setValue(
             StoreManagerInterface::CONTEXT_STORE,
@@ -97,7 +110,7 @@ private function isAlreadySet(): bool
 
         return $this->httpContext->getValue($storeKey) !== null;
     }
-    
+
     /**
      * Check if provided store code exist
      *
@@ -112,4 +125,4 @@ private function isStoreValid(string $storeCode): bool
         }
         return false;
     }
-}
+}

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchWithTranslatedMessageTest.php

@@ -0,0 +1,51 @@
+<?php
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\GraphQl\Catalog;
+
+use Magento\TestFramework\TestCase\GraphQlAbstract;
+use Magento\TestFramework\Helper\CacheCleaner;
+
+/**
+ * The GraphQl test for product in non default store with different locale
+ */
+class ProductSearchWithTranslatedMessageTest extends GraphQlAbstract
+{
+    /**
+     * Test translated error message in non default store
+     *
+     * @magentoApiDataFixture Magento/Store/_files/second_store.php
+     * @magentoApiDataFixture Magento/Translation/_files/catalog_message_translate.php
+     * @magentoConfigFixture fixture_second_store_store general/locale/code nl_NL
+     */
+    public function testErrorMessageTranslationInNonDefaultLocale()
+    {
+        CacheCleaner::clean(['translate', 'config']);
+        $storeCode = "fixture_second_store";
+        $header = ['Store' => $storeCode];
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('currentPage-waarde moet groter zijn dan 0.');
+        $this->graphQlQuery($this->getQuery(), [], '', $header);
+    }
+
+
+    private function getQuery()
+    {
+        return <<<QUERY
+        {
+            products( currentPage: 0) {
+                items {
+                    id
+                    name
+                }
+            }
+        }
+        QUERY;
+    }
+}

dev/tests/integration/testsuite/Magento/Translation/_files/catalog_message_translate.php

@@ -0,0 +1,13 @@
+<?php
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+/** @var \Magento\Translation\Model\ResourceModel\StringUtils $translateString */
+$translateString = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+    \Magento\Translation\Model\ResourceModel\StringUtils::class
+);
+$translateString->saveTranslate('currentPage value must be greater than 0.', 'currentPage-waarde moet groter zijn dan 0.', "nl_NL", 0);

dev/tests/integration/testsuite/Magento/Translation/_files/catalog_message_translate_rollback.php

@@ -0,0 +1,13 @@
+<?php
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+/** @var \Magento\Translation\Model\ResourceModel\StringUtils $translateString */
+$translateString = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+    \Magento\Translation\Model\ResourceModel\StringUtils::class
+);
+$translateString->deleteTranslate('currentPage value must be greater than 0.', "nl_NL", 0);