Added test coverage

Author: rogyar

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/SpecialPrice.php

@@ -24,13 +24,13 @@ class SpecialPrice implements ResolverInterface
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
-        /** @var ProductInterface $product */
-        $product = $value['model'];
-
         if (!isset($value['model'])) {
             throw new LocalizedException(__('"model" value should be specified'));
         }
 
+        /** @var ProductInterface $product */
+        $product = $value['model'];
+
         /** @var PricingSpecialPrice $specialPrice */
         $specialPrice = $product->getPriceInfo()->getPrice(PricingSpecialPrice::PRICE_CODE);
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductPriceTest.php

@@ -832,6 +832,73 @@ public function testProductWithCatalogDiscount()
         }
     }
 
+    /**
+     * Check if the special price visible if the current date is in the date range set
+     * for the special price
+     *
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_special_price.php
+     */
+    public function testSpecialPriceVisibleIfInDateRange()
+    {
+        $query = <<<QUERY
+{
+    products(filter: {sku: {eq: "simple_product"}}) {
+        items {
+            price_range {
+                minimum_price {
+                    regular_price {
+                        value
+                    }
+                }
+            }
+            special_price
+        }
+    }
+}
+QUERY;
+        $result = $this->graphQlQuery($query);
+        $productInformation = $result['products']['items'][0];
+        $productRegularPrice = $productInformation['price_range']['minimum_price']['regular_price']['value'];
+
+        self::assertEquals('10', $productRegularPrice);
+        self::assertEquals('5.99', $productInformation['special_price']);
+    }
+
+
+    /**
+     * Check if the special price is not visible if the current date is not in the date range set
+     * for the special price
+     *
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_special_price_future_date.php
+     */
+    public function testSpecialPriceNotVisibleIfNotInDateRange()
+    {
+        $query = <<<QUERY
+{
+    products(filter: {sku: {eq: "simple_product"}}) {
+        items {
+            price_range {
+                minimum_price {
+                    regular_price {
+                        value
+                    }
+                }
+            }
+            special_price
+        }
+    }
+}
+QUERY;
+        $result = $this->graphQlQuery($query);
+        $productInformation = $result['products']['items'][0];
+        $productRegularPrice = $productInformation['price_range']['minimum_price']['regular_price']['value'];
+
+        self::assertEquals('10', $productRegularPrice);
+        self::assertEquals(null, $productInformation['special_price']);
+    }
+
     /**
      * Get GraphQl query to fetch products by sku
      *
@@ -909,7 +976,7 @@ private function getQueryConfigurableProductAndVariants(array $sku): string
       name
       sku
       price_range {
-        minimum_price {regular_price 
+        minimum_price {regular_price
         {
          value
          currency
@@ -949,13 +1016,13 @@ private function getQueryConfigurableProductAndVariants(array $sku): string
       ... on ConfigurableProduct{
         variants{
           product{
-           
+
             sku
             price_range {
         minimum_price {regular_price {value}
           final_price {
             value
-            
+
           }
           discount {
             amount_off
@@ -965,11 +1032,11 @@ private function getQueryConfigurableProductAndVariants(array $sku): string
         maximum_price {
           regular_price {
             value
-           
+
           }
           final_price {
             value
-            
+
           }
           discount {
             amount_off
@@ -985,7 +1052,7 @@ private function getQueryConfigurableProductAndVariants(array $sku): string
               final_price{value}
                 quantity
               }
-            
+
             }
           }
         }

dev/tests/integration/testsuite/Magento/GraphQl/Catalog/_files/set_simple_product_special_price.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var ProductRepositoryInterface $productRepository */
+$productRepository = $objectManager->get(ProductRepositoryInterface::class);
+
+$product = $productRepository->get('simple_product');
+$product->setSpecialPrice('5.99');
+
+$product->setSpecialFromDate(date('Y-m-d', strtotime('-1 day')));
+$product->setSpecialToDate(date('Y-m-d', strtotime('+1 day')));
+
+$productRepository->save($product);

dev/tests/integration/testsuite/Magento/GraphQl/Catalog/_files/set_simple_product_special_price_future_date.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var ProductRepositoryInterface $productRepository */
+$productRepository = $objectManager->get(ProductRepositoryInterface::class);
+
+$product = $productRepository->get('simple_product');
+$product->setSpecialPrice('5.99');
+
+$product->setSpecialFromDate(date('Y-m-d', strtotime('+3 day')));
+$product->setSpecialToDate(date('Y-m-d', strtotime('+5 day')));
+
+$productRepository->save($product);